Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with _extends values #511

Open
Raphael-Gazzotti opened this issue Sep 10, 2024 · 2 comments
Open

Inconsistencies with _extends values #511

Raphael-Gazzotti opened this issue Sep 10, 2024 · 2 comments

Comments

@Raphael-Gazzotti
Copy link
Member

Paths should start with the “/” character or without. But we should not see both cases.

Non-exhaustive examples:
(Sample of schemas in openMINDS_SANDS)

Sample of “schemas/atlas/atlasAnnotation.schema.tpl.json”

{ 

  "_type": "https://openminds.ebrains.eu/sands/AtlasAnnotation", 

  "_extends": "atlas/annotation.schema.tpl.json", 

... 

Sample of “schemas/atlas/brainAtlas.schema.tpl.json”

{ 

  "_type": "https://openminds.ebrains.eu/sands/BrainAtlas", 

  "_extends": "/core/schemas/products/researchProduct.schema.tpl.json",
...
@apdavison
Copy link
Member

apdavison commented Sep 11, 2024

The concept is that paths starting with "/" are absolute paths, used to refer to schemas in other repositories (i.e. other sub-modules), while paths without "/" are relative to the current repository/submodule.

We could make all paths absolute, but I don't see the current usage as inconsistent.

@lzehl
Copy link
Member

lzehl commented Jan 20, 2025

It is indeed not inconsistent, but we should discuss this anyway. @Raphael-Gazzotti could you check the relevant section in the pipeline so we know what effect harmonizing to absolute path would have there on the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants