Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"TermSuggestion" is not really a "controlledTerm" #449

Open
olinux opened this issue Sep 4, 2023 · 2 comments
Open

"TermSuggestion" is not really a "controlledTerm" #449

olinux opened this issue Sep 4, 2023 · 2 comments
Labels
major update large workload or major update needed to complete question further information is requested
Milestone

Comments

@olinux
Copy link
Member

olinux commented Sep 4, 2023

Whilst updating the ingestion mechanism, I figured out one inconsistency in "controlledTerms" - the "TermSuggestion" is (by definition) not really a "controlledTerm" but its instances are supposed to be dynamic. I'm therefore wondering if it shouldn't be moved towards "core".

https://github.com/HumanBrainProject/openMINDS_controlledTerms/blob/0f6c0fa912fd40fe560a3e419fc88524ef7454d2/schemas/termSuggestion.schema.tpl.json#L2

@lzehl
Copy link
Member

lzehl commented Sep 4, 2023

@olinux I actually think "controlledTerm" is a poor naming from our side at the beginning. In principle this repository (and the connected schema types) should be renamed to "terms" or to "terminologies". This is a huge change though which I'm not sure we want to introduce now. Your thoughts?

@lzehl
Copy link
Member

lzehl commented Sep 4, 2023

openMINDS dev meeting decision: we should better document this odd schema for now and discuss changing the name of the "controlledTerms" to "terms" or "terminologies" for a new major release of openMINDS.

@apdavison apdavison added this to the version 2 milestone Sep 4, 2023
@UlrikeS91 UlrikeS91 added question further information is requested major update large workload or major update needed to complete labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major update large workload or major update needed to complete question further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants