Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problematic BIDS examples #21

Open
spieschnik opened this issue Apr 12, 2024 · 7 comments
Open

Problematic BIDS examples #21

spieschnik opened this issue Apr 12, 2024 · 7 comments

Comments

@spieschnik
Copy link

spieschnik commented Apr 12, 2024 •
edited
Loading

An issue to report all problematic BIDS examples and their errors
@spieschnik
Copy link
Author

Error for ds000247:

ds000247

@spieschnik
Copy link
Author

Error for eeg_cbm:
eeg_cbm

@spieschnik
Copy link
Author

Error for asl001:

asl001

@Peyman-N
Copy link
Member

Hi @spieschnik, could you please rerun these with the latest version? I did it on my machine, and they ran, but there still could be a problem, especially the last one, which might only occur on your PC.

apdavison added a commit to apdavison/bids2openminds that referenced this issue Apr 16, 2024
@apdavison
Add problematic examples from openMetadataInitiative#21 to test suite
55ffa65
@spieschnik
Copy link
Author

Still the same errors when using the newest version (bids2poenminds-number_of_files), the file count works!

eeg_cbm
image

asl001
image

apdavison added a commit that referenced this issue Apr 16, 2024
@apdavison
Merge pull request #27 from apdavison/more-tests
5edbb77 
Add problematic examples from #21 to test suite
@apdavison apdavison mentioned this issue Apr 16, 2024
Merged
@apdavison
Copy link
Member

I've added these problematic examples to the test suite, which now runs on Windows, Linux and Mac OS, and all tests pass with the latest "main" branch.

In general, when you find other examples that produce errors, please add then to the list "example_dataset_labels" in the test_bids_examples.py file.

@lzehl
Copy link
Member

lzehl commented Apr 17, 2024

@Peyman-N or @spieschnik you can add "ds000001-fmriprep" from the previous issue #18 to the example_dataset_labels in the test_bids_examples.py

@spieschnik spieschnik mentioned this issue Apr 18, 2024
Closed
@Peyman-N Peyman-N linked a pull request May 21, 2024 that will close this issue
Dealing with derivatives #45
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dealing with derivatives Peyman-N/bids2openminds
4 participants
@apdavison @lzehl @Peyman-N @spieschnik