-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise warnings when special tags are misspelled, or missing spaces #501
Comments
I looked into this, the issue is my parser isn't accurately pulling HTML comments and then parsing the content within it. Specifically, it's requiring space to parse the id. That is, we're parsing:
I think this could be fixed by created a generic HTML comment parser that captures the content between I'll try to get to this after my latest Go bug fixes unless someone else has time to address it. |
Hello, I’m new to contributing to open source projects and I thought this would be a beginner-friendly issue, can I attempt this? |
@jsuereth It looks like the changes in your PR works fine with the current tests. Could you provide a specific example or input where the current solution isn't working as expected? This will help me better understand the issue. |
Describe the bug
A small "typo" like
<!-- semconv metric.k8s.hpa.min_pods-->
(missing space before-->
) makes the tooling producing no markdown tables without raising a warning for this.Raising a warning would definitely help on troubleshooting cause usually these kind of typos are hard to spot :).
To Reproduce
Use a metric tag like
<!-- semconv metric.k8s.hpa.min_pods-->
and try to generate the markdowns (make fix
).Expected behavior
A clear and concise description of what you expected to happen.
At least a warning should let users know what wrong with that tag.
Additional context
Add any other context about the problem here.
ref: https://cloud-native.slack.com/archives/C041APFBYQP/p1733311696182559
The text was updated successfully, but these errors were encountered: