Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[outreachy] Registry: no entries found visualization #5372

Closed
svrnm opened this issue Oct 10, 2024 · 5 comments · May be fixed by #5462
Closed

[outreachy] Registry: no entries found visualization #5372

svrnm opened this issue Oct 10, 2024 · 5 comments · May be fixed by #5462
Assignees
@JennySimen
Labels
enhancement New feature or request outreachy Issues for Outreachy Participants registry

Comments

@svrnm
Copy link
Member

svrnm commented Oct 10, 2024

Outreachy task for @JennySimen

Thank you for filling out the user experience report, please provide the following improvement via a PR:

When an end user provides a search term and no entries can be found, they currently see a blank page. Please provide a visually appealing solution that will be demonstrated to the user, when there is no entry. Your solution can include images, suggestions to the end user, what they can do next, etc. Feel free to use other search engines "no result" pages as inspiration

Note: This is an assigned issue for a participant that has completed the user experience report, if you are an outreachy participant as well, find instructions here: #5290
@svrnm svrnm added enhancement New feature or request registry outreachy Issues for Outreachy Participants labels Oct 10, 2024
@JennySimen
Copy link

Hi @svrnm please I would like a bit of clarification on the issue, will I need to create a new page to be displayed when no search results in found?

@svrnm
Copy link
Member Author

svrnm commented Oct 16, 2024

You will need to edit the existing page here: https://github.com/open-telemetry/opentelemetry.io/blob/main/layouts/shortcodes/ecosystem/registry/search-form.html

At the bottom you see where the items are listed, you need to add some checks that there are no entries and then display something to the user that tells them that nothing was found, and give them some ideas how to improve their search, or a nice visualization showing them that they hit an empty page

@JennySimen
Copy link

Oh ok, thank you for the clarification.

@svrnm
Copy link
Member Author

svrnm commented Oct 22, 2024

Thank you for participating in the outreachy participation phase, @JennySimen! As announced in the channel and in the meta issue I closed the project for new contributors. Since you have not registered and also not provided a PR for this issue, I will close this now

@svrnm svrnm closed this as completed Oct 22, 2024
@svrnm
Copy link
Member Author

svrnm commented Oct 22, 2024

Important

The deadline to register for the project via the outreachy platform has been extended until Oct 23 7am UTC. If you still want to participate, please make sure that you record at least one contribution to the "OpenTelemetry Registry" project. When you are registered I will reopen this issue.

JennySimen added a commit to JennySimen/opentelemetry.io that referenced this issue Oct 23, 2024
@JennySimen
feat: no search entries found page (open-telemetry#5372)
667a979
@JennySimen JennySimen mentioned this issue Oct 23, 2024
Open
JennySimen added a commit to JennySimen/opentelemetry.io that referenced this issue Oct 25, 2024
@JennySimen
feat: no search entries found page (open-telemetry#5372)
ffa893e
chalin pushed a commit to JennySimen/opentelemetry.io that referenced this issue Dec 5, 2024
@JennySimen @chalin
feat: no search entries found page (open-telemetry#5372)
3a21706
chalin pushed a commit to JennySimen/opentelemetry.io that referenced this issue Dec 5, 2024
@JennySimen @chalin
feat: no search entries found page (open-telemetry#5372)
a7783ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JennySimen JennySimen

Labels
enhancement New feature or request outreachy Issues for Outreachy Participants registry
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: no search entries found page (#5372) JennySimen/opentelemetry.io
2 participants
@svrnm @JennySimen