File tree 2 files changed +9
-0
lines changed
2 files changed +9
-0
lines changed Original file line number Diff line number Diff line change 17
17
` Error ` which contained many variants unrelated to building an exporter, the
18
18
new one returns specific variants applicable to building an exporter. Some
19
19
variants might be applicable only on select features.
20
+ - * Breaking*
21
+ [ #2779 ] ( https://github.com/open-telemetry/opentelemetry-rust/issues/2779 ) handle
22
+ shutdown for span exporter for ` http ` exporters, shutdown for ` grpc ` would be added
23
+ separately.
20
24
21
25
## 0.28.0
22
26
Original file line number Diff line number Diff line change @@ -90,6 +90,11 @@ impl SpanExporter for TonicTracesClient {
90
90
}
91
91
92
92
fn shutdown ( & self ) -> OTelSdkResult {
93
+ // ToDo: as part of https://github.com/open-telemetry/opentelemetry-rust/pull/2812
94
+ // self is no longer mutable due to trait change for span exporter
95
+ // the shutdown for gRPC needs to implemented and tracked in
96
+ // https://github.com/open-telemetry/opentelemetry-rust/issues/2777
97
+ //
93
98
// match self.inner.take() {
94
99
// Some(_) => Ok(()), // Successfully took `inner`, indicating a successful shutdown.
95
100
// None => Err(OTelSdkError::AlreadyShutdown), // `inner` was already `None`, meaning it's already shut down.
You can’t perform that action at this time.
0 commit comments