Skip to content

Commit ffd3244

Browse files
chore: add changelog and todo
Signed-off-by: Shivanshu Raj Shrivastava <[email protected]>
1 parent 776039a commit ffd3244

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

opentelemetry-otlp/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@
1717
`Error` which contained many variants unrelated to building an exporter, the
1818
new one returns specific variants applicable to building an exporter. Some
1919
variants might be applicable only on select features.
20+
- *Breaking*
21+
[#2779](https://github.com/open-telemetry/opentelemetry-rust/issues/2779) handle
22+
shutdown for span exporter for `http` exporters, shutdown for `grpc` would be added
23+
separately.
2024

2125
## 0.28.0
2226

opentelemetry-otlp/src/exporter/tonic/trace.rs

+5
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,11 @@ impl SpanExporter for TonicTracesClient {
9090
}
9191

9292
fn shutdown(&self) -> OTelSdkResult {
93+
// ToDo: as part of https://github.com/open-telemetry/opentelemetry-rust/pull/2812
94+
// self is no longer mutable due to trait change for span exporter
95+
// the shutdown for gRPC needs to implemented and tracked in
96+
// https://github.com/open-telemetry/opentelemetry-rust/issues/2777
97+
//
9398
// match self.inner.take() {
9499
// Some(_) => Ok(()), // Successfully took `inner`, indicating a successful shutdown.
95100
// None => Err(OTelSdkError::AlreadyShutdown), // `inner` was already `None`, meaning it's already shut down.

0 commit comments

Comments
 (0)