Skip to content

Commit 8e0857d

Browse files
authored
fix: outdated examples in opentelemetry-jaeger. (#455)
1 parent 14f6e00 commit 8e0857d

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

opentelemetry-jaeger/README.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ Then install a new jaeger pipeline with the recommended defaults to start
4242
exporting telemetry:
4343

4444
```rust
45-
use opentelemetry::tracer;
4645
use opentelemetry::global;
46+
use opentelemetry::trace::Tracer;
4747

4848
fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
4949
global::set_text_map_propagator(opentelemetry_jaeger::Propagator::new());
@@ -85,8 +85,8 @@ in the [jaeger variables spec].
8585
[jaeger variables spec]: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-environment-variables.md#jaeger-exporter
8686

8787
```rust
88-
use opentelemetry::tracer;
8988
use opentelemetry::global;
89+
use opentelemetry::trace::Tracer;
9090

9191
fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
9292
global::set_text_map_propagator(opentelemetry_jaeger::Propagator::new());
@@ -126,7 +126,7 @@ Then you can use the [`with_collector_endpoint`] method to specify the endpoint:
126126
// You can also provide your own implementation by enable
127127
// `collecor_client` and set it with
128128
// new_pipeline().with_http_client() method.
129-
use opentelemetry::tracer;
129+
use opentelemetry::trace::Tracer;
130130

131131
fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
132132
let (tracer, _uninstall) = opentelemetry_jaeger::new_pipeline()
@@ -152,9 +152,13 @@ Example showing how to override all configuration options. See the
152152
[`PipelineBuilder`]: https://docs.rs/opentelemetry-jaeger/latest/opentelemetry_jaeger/struct.PipelineBuilder.html
153153

154154
```rust
155-
use opentelemetry::{KeyValue, Tracer};
156-
use opentelemetry::sdk::{trace, IdGenerator, Resource, Sampler};
157155
use opentelemetry::global;
156+
use opentelemetry::sdk::{
157+
trace::{self, IdGenerator, Sampler},
158+
Resource,
159+
};
160+
use opentelemetry::trace::Tracer;
161+
use opentelemetry::KeyValue;
158162

159163
fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
160164
global::set_text_map_propagator(opentelemetry_jaeger::Propagator::new());
@@ -163,7 +167,6 @@ fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
163167
.with_agent_endpoint("localhost:6831")
164168
.with_service_name("my_app")
165169
.with_tags(vec![KeyValue::new("process_key", "process_value")])
166-
.with_max_packet_size(65_000)
167170
.with_trace_config(
168171
trace::config()
169172
.with_default_sampler(Sampler::AlwaysOn)

0 commit comments

Comments
 (0)