Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-instrumentation-aws-lambda] cloud.account.id to be set as span attribute instead of resource attribute #2547

Open
1 of 2 tasks
calindurnea opened this issue Nov 22, 2024 · 2 comments

Comments

@calindurnea
Copy link

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

I have previously opened a bug #2463 related to cloud account id resource attribute being mapped to labels.cloud_account_id instead of cloud.account.id in elastic.

This was closed as it was not considered a bug with OpenTelemetry, but another person brought up a point that it might actually be a misconfiguration in the opentelemetry-instrumentation-aws-lambda instrumentation.

in this case, the bug is with the instrumentation. cloud.account.id is a resource attribute, but the instrumentation is setting it as a span attribute:

I was not able to get any replies to this in that thread, so I would like to open this discussion to figure out if that is an actual bug or not.

If this is not the correct template for that, please let me know and i will try to fix it.

@pichlermarc
Copy link
Member

Yep, resource attributes should not go onto a span, that's correct. I think that might be incorrect in the current implementation here.

@calindurnea
Copy link
Author

@pichlermarc thank you for the reply.

Would that mean that this attribute would be better fitted in the "opentelemetry-resource-detector-aws" package rather than here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants