Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding instrumentation support for Ratpack 2.x version #12962

Open
NaveenRamu opened this issue Dec 23, 2024 Discussed in #12960 · 1 comment
Open

Adding instrumentation support for Ratpack 2.x version #12962

NaveenRamu opened this issue Dec 23, 2024 Discussed in #12960 · 1 comment
Labels
needs author feedback Waiting for additional feedback from the author

Comments

@NaveenRamu
Copy link

Discussed in #12960

Originally posted by NaveenRamu December 23, 2024
As suggested in the Git issue, I have copied the 1.7 instrumentation module and aligned the imports to Ratpack 2.x.

Questions:

  1. How will the changes be pushed to the opentelemetry-java-instrumentation repo, as I don't have permission to push them?
  2. If I don't receive permission to push the changes, how can I use these changes and write manual instrumentation (since manual instrumentation requires SDK and API dependencies)?
@laurit
Copy link
Contributor

laurit commented Dec 30, 2024

How will the changes be pushed to the opentelemetry-java-instrumentation repo, as I don't have permission to push them?

you'll push them into your own fork and create a pull request

If I don't receive permission to push the changes, how can I use these changes and write manual instrumentation (since manual instrumentation requires SDK and API dependencies)?

I don't quite follow this. SDK and API are available in maven central. You can publish the manual instrumentation library for ratpack 2, that you created by copying the ratpack 1 library, wherever you publish your other jars.

@laurit laurit added the needs author feedback Waiting for additional feedback from the author label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs author feedback Waiting for additional feedback from the author
Projects
None yet
Development

No branches or pull requests

2 participants