Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AWS]: always add context propagation data to requests #2447

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cfbao
Copy link

@cfbao cfbao commented Dec 25, 2024

Fixes #2345

Changes

Move code that adds context propagation data to requests into a dedicated method AddPropagationDataToRequest, and always run that regardless of sampling decision.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Copy link

linux-foundation-easycla bot commented Dec 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS label Dec 25, 2024
@cfbao
Copy link
Author

cfbao commented Dec 25, 2024

There's no existing unit tests in this area, but I've verified that correctly adds relevant message attribute to SQS requests using the script showed in #2345.

@cfbao cfbao marked this pull request as ready for review December 25, 2024 03:16
@cfbao cfbao requested a review from a team as a code owner December 25, 2024 03:16
Copy link
Member

@ppittle ppittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfbao - Thank you for the contribution!

There's no existing unit tests in this area, but I've verified that correctly adds relevant message attribute to SQS requests using the script showed in #2345.

Would it be possible to add some unit test coverage around this feature?

Otherwise, this looks good to me.

@cfbao
Copy link
Author

cfbao commented Jan 1, 2025

@ppittle Oh I missed what these instrumentation tests were doing.
Added coverage on SQS message attributes for both sampled and not sampled requests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] AWS instrumentation not adding request specific info on requests *not* sampled
5 participants