-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AWS]: always add context propagation data to requests #2447
base: main
Are you sure you want to change the base?
Conversation
There's no existing unit tests in this area, but I've verified that correctly adds relevant message attribute to SQS requests using the script showed in #2345. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cfbao - Thank you for the contribution!
There's no existing unit tests in this area, but I've verified that correctly adds relevant message attribute to SQS requests using the script showed in #2345.
Would it be possible to add some unit test coverage around this feature?
Otherwise, this looks good to me.
@ppittle Oh I missed what these instrumentation tests were doing. |
Fixes #2345
Changes
Move code that adds context propagation data to requests into a dedicated method
AddPropagationDataToRequest
, and always run that regardless of sampling decision.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes