Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extension/jaegerremotesampling dependency on JAEGER/cmd/collector/app/sampling #36976

Open
ary82 opened this issue Dec 28, 2024 · 1 comment · May be fixed by #36977
Open

Remove extension/jaegerremotesampling dependency on JAEGER/cmd/collector/app/sampling #36976

ary82 opened this issue Dec 28, 2024 · 1 comment · May be fixed by #36977
Labels
extension/jaegerremotesampling needs triage New item requiring triage

Comments

@ary82
Copy link

ary82 commented Dec 28, 2024

Component(s)

extension/jaegerremotesampling

Describe the issue you're reporting

In extension/jaegerremotesampling,

  1. The internal package has the following dependencies:

    • The Provider interface from JAEGER/cmd/collector/app/sampling/samplingstrategy
    • The GRPCHandler struct from JAEGER/cmd/collector/app/sampling

  2. As for the root package in extension/jaegerremotesampling, it depends on the code from:

    • JAEGER/plugin/sampling/strategyprovider/static/options.go
    • JAEGER/plugin/sampling/strategyprovider/static/providers.go

jaegertracing/jaeger#6411
@ary82 ary82 added the needs triage New item requiring triage label Dec 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@ary82 ary82 linked a pull request Dec 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension/jaegerremotesampling needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
1 participant
@ary82