fix: replace plus character with underscore in version label #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filippo Rossi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3742 +/- ##
==========================================
- Coverage 54.49% 47.56% -6.93%
==========================================
Files 134 236 +102
Lines 12329 19923 +7594
==========================================
+ Hits 6719 9477 +2758
- Misses 5116 9553 +4437
- Partials 494 893 +399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ritazh
approved these changes
Dec 14, 2024
|
@maxsmythe PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the chart version contains a
+character, the app.kubernetes.io/version label value is rendered from the chart version as is causing invalid character errors in the label.This PR fixes this behavior by replacing the '+' character with a "_'.
Fixes #3741