mpi: incorporate review comments

Incorporate the comments received during the review of the PR.

Signed-off-by: Edgar Gabriel <[email protected]>

Author: edgargabriel

docs/man-openmpi/man3/MPI_Request_get_status_all.3.rst

@@ -31,14 +31,15 @@ operations associated with *active* handles in the array have completed.
 In this case, each status entry that corresponds to an active request
 is set to the status of the corresponding operation. It
 does not deallocate or deactivate the request; a subsequent call to
-test, wait, or free should be executed with each of those requests.
+any of the MPI test, wait, or free routines should be executed with each
+of those requests.
 
 Each status entry that corresponds to a null or inactive handle is set
 to empty.  Otherwise, ``flag = false`` is returned and the values of the
 status entries are undefined.
 
 If your application does not need to examine the *status* field, you can
-save resources by using the predefined constant ``MPI_STATUS_IGNORE`` as a
+save resources by using the predefined constant ``MPI_STATUSES_IGNORE`` as a
 special value for the ``array_of_statuses`` argument.
 
 

docs/man-openmpi/man3/MPI_Request_get_status_any.3.rst

@@ -31,8 +31,8 @@ DESCRIPTION
 of the operations associated with active handles has completed. In
 this case it returns in ``index`` the index of this request in the
 array and the status of the operation in ``status``.  It does not
-deallocate or deactivate the request; a subsequent call to test, wait,
-or free should be executed with that request.
+deallocate or deactivate the request; a subsequent call to any of the MPI
+test, wait, or free routines should be executed with that request.
 
 If no operation completed, it returns ``flag = false`` and a value of
 ``MPI_UNDEFINED`` in ``index``. ``status`` is undefined in this

docs/man-openmpi/man3/MPI_Request_get_status_some.3.rst

@@ -34,15 +34,15 @@ first ``outcount`` locations of the array ``array_of_indices`` and
 within the array ``array_of_requests`` and the status of these
 operations respectively. The array is indexed from zero in C and from
 one in Fortran. It does not deallocate or deactivate the request; a
-subsequent call to test, wait, or free should be executed with each completed
-request.
+subsequent call to any of the MPI test, wait, or free routines should be
+executed with each completed request.
 
 If no operation in ``array_of_requests`` is complete, it returns
 ``outcount = 0``. If all operations in ``array_of_requests`` are either
 ``MPI_REQUEST_NULL`` or inactive, ``outcount`` will be set to ``MPI_UNDEFINED``.
 
 If your application does not need to examine the *status* field, you can
-save resources by using the predefined constant ``MPI_STATUS_IGNORE`` as a
+save resources by using the predefined constant ``MPI_STATUSES_IGNORE`` as a
 special value for the ``array_of_statuses`` argument.
 
 

ompi/mpi/c/request_get_status_all.c.in

@@ -70,36 +70,32 @@ PROTOTYPE ERROR_CLASS request_get_status_all(INT count, REQUEST_CONST requests:c
     }
 
     bool all_done;
-    bool one_done;
 
 #if OPAL_ENABLE_PROGRESS_THREADS == 0
-    int do_it_once = 0;
+    bool do_it_once = true;
  recheck_request_status:
 #endif
 
     opal_atomic_mb();
     int i;
     all_done = true;
     for (i = 0; i < count; i++) {
-        one_done = false;
         if( (requests[i] == MPI_REQUEST_NULL) || (requests[i]->req_state == OMPI_REQUEST_INACTIVE) ||
             (requests[i]->req_complete) ) {
             continue;
         }
-        if (!one_done) {
-            all_done = false;
-            break;
-        }
+	all_done = false;
+	break;
     }
 
     if (!all_done) {
 #if OPAL_ENABLE_PROGRESS_THREADS == 0
-        if( 0 == do_it_once ) {
+        if(do_it_once) {
             /* If we run the opal_progress then check the status of the
                request before leaving. We will call the opal_progress only
                once per call. */
             opal_progress();
-            do_it_once++;
+            do_it_once = false;
             goto recheck_request_status;
         }
 #endif

ompi/mpi/c/request_get_status_any.c.in

@@ -77,7 +77,7 @@ PROTOTYPE ERROR_CLASS request_get_status_any(INT count, REQUEST_CONST requests:c
     bool all_inactive;
 
 #if OPAL_ENABLE_PROGRESS_THREADS == 0
-    int do_it_once = 0;
+    bool do_it_once = true;
  recheck_request_status:
 #endif
 
@@ -117,12 +117,12 @@ PROTOTYPE ERROR_CLASS request_get_status_any(INT count, REQUEST_CONST requests:c
     }
 
 #if OPAL_ENABLE_PROGRESS_THREADS == 0
-    if( 0 == do_it_once ) {
+    if(do_it_once) {
         /* If we run the opal_progress then check the status of the
            request before leaving. We will call the opal_progress only
            once per call. */
         opal_progress();
-        do_it_once++;
+        do_it_once = false;
         goto recheck_request_status;
     }
 #endif

ompi/mpi/c/request_get_status_some.c.in

@@ -73,7 +73,7 @@ PROTOTYPE ERROR_CLASS request_get_status_some(INT incount, REQUEST_CONST request
     bool all_inactive;
 
 #if OPAL_ENABLE_PROGRESS_THREADS == 0
-    int do_it_once = 0;
+    bool do_it_once = true;
  recheck_request_status:
 #endif
 
@@ -112,12 +112,12 @@ PROTOTYPE ERROR_CLASS request_get_status_some(INT incount, REQUEST_CONST request
     }
 
 #if OPAL_ENABLE_PROGRESS_THREADS == 0
-    if( 0 == do_it_once ) {
+    if(do_it_once) {
         /* If we run the opal_progress then check the status of the
            request before leaving. We will call the opal_progress only
            once per call. */
         opal_progress();
-        do_it_once++;
+        do_it_once = false;
         goto recheck_request_status;
     }
 #endif