Merge pull request #10 from cniethammer/fix-tst_env_get_version

cniethammer · web-flow · commit 9776143c01f3 · 2023-02-16T15:14:23.000+01:00
Fix array out-of-bounds access in tst_env_get_version
diff --git a/env/tst_env_get_version.c b/env/tst_env_get_version.c
@@ -32,7 +32,7 @@ int tst_env_get_version_run (struct tst_env * env)
 
   int valid_mpi_versions[][2] = { {3,1}, {3,0}, {2,2}, {2,1}, {2,0}, {1,2} };
   int i;
-  for( i = 0; i < sizeof(valid_mpi_versions); i++) {
+  for( i = 0; i < (sizeof(valid_mpi_versions)/sizeof(valid_mpi_versions[0])); i++) {
     if( valid_mpi_versions[i][0] == version && valid_mpi_versions[i][1] == subversion) {
       return 0;
     }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ int tst_env_get_version_run (struct tst_env * env)`
`32`	`32`
`33`	`33`	`int valid_mpi_versions[][2] = { {3,1}, {3,0}, {2,2}, {2,1}, {2,0}, {1,2} };`
`34`	`34`	`int i;`
`35`		`- for( i = 0; i < sizeof(valid_mpi_versions); i++) {`
	`35`	`+ for( i = 0; i < (sizeof(valid_mpi_versions)/sizeof(valid_mpi_versions[0])); i++) {`
`36`	`36`	`if( valid_mpi_versions[i][0] == version && valid_mpi_versions[i][1] == subversion) {`
`37`	`37`	`return 0;`
`38`	`38`	`}`