Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsaved changes dialog #4650

Open
Liew211 opened this issue Aug 22, 2019 · 1 comment · May be fixed by #8032
Open

Unsaved changes dialog #4650

Liew211 opened this issue Aug 22, 2019 · 1 comment · May be fixed by #8032
Assignees
@jessewashburn
Labels
reopen? valid

Comments

@Liew211
Copy link
Member

Liew211 commented Aug 22, 2019

When editing details, profile, etc, there should be a dialog when the user attempts to leave the page, say "You have unsaved changes, are you sure you want to leave the page?"
@paulbert
Copy link
Member

This is pretty broad. Let's start by creating a service and then implementing on one form (MeetupsAddComponent would be my suggestion). Once we've worked out the issues with that, we can implement across other forms that need it.

@RheuX RheuX added the reopen? label Nov 13, 2024
@Mutugiii Mutugiii added the valid label Nov 18, 2024
@jessewashburn jessewashburn self-assigned this Nov 19, 2024
@jessewashburn jessewashburn linked a pull request Jan 2, 2025 that will close this issue
edit-profile: smoother unsaved changes (fixes #4650) #8032
Open
@jessewashburn jessewashburn linked a pull request Jan 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessewashburn jessewashburn

Labels
reopen? valid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

edit-profile: smoother unsaved changes (fixes #4650) open-learning-exchange/planet
5 participants
@paulbert @Liew211 @Mutugiii @RheuX @jessewashburn