-
Notifications
You must be signed in to change notification settings - Fork 47
Open
Description
Problem
The CLUSTER_DOMAIN environment variable introduced in PR #789 does not follow the naming convention used by other flagd-related configuration options in the operator.
Current Behavior
The environment variable for configuring the Kubernetes cluster domain is named CLUSTER_DOMAIN, which is inconsistent with other flagd-related environment variables.
Expected Behavior
All flagd-related configuration options should follow a consistent naming pattern with the FLAGD_ prefix:
FLAGD_PROXY_PORTFLAGD_PROXY_IMAGEFLAGD_PROXY_TAGFLAGD_CLUSTER_DOMAIN← should follow this pattern
Impact
Inconsistent naming makes configuration more confusing and harder to discover. Users expect related options to share a common prefix for easier grouping and documentation.
Solution
Rename the environment variable from CLUSTER_DOMAIN to FLAGD_CLUSTER_DOMAIN in the envconfig.
Related
- PR fix(envconfig): rename CLUSTER_DOMAIN env var to FLAGD_CLUSTER_DOMAIN #792 fixes this issue
- PR feat: add configurable cluster domain support #789 introduced the original
CLUSTER_DOMAINconfiguration - Issue Flagd-proxy mode assumes cluster.local #764 was the original request for configurable cluster domain support
kuznero, SilasPihl and SebastianBalle
Metadata
Metadata
Assignees
Labels
No labels