DataStore Foreign Keys by JVickery-TBS · Pull Request #181 · open-data/ckan

JVickery-TBS · 2024-08-16T20:14:38Z

Help me.

- Started working on fereign key constraints for the datastore.

ckanext/datastore/backend/postgres.py

- Continued working on fereign key constraints for the datastore.

JVickery-TBS · 2024-08-20T02:18:01Z

Okay we got foreign keys working on datastore_create, with the create_table and alter_table back-end methods (might be a better way to do the alter_table one, for checking current constraints but not sure. I tried a couple things and think I landed on a good one).

I ended up doing a hash for the foreign key constraint name based on foreign table, primary columns, and foreign columns. I think that should work out as the hashes should get generated the same based on the names.

Figured that the constraint name did not matter if we can get the constraints outputted in the datastore_info action for a field. So fields will, in theory, have a foreignkeys attribute returned, either as None or as a parsed out version of the foreign table and foreign columns.

Once I have the datastore_info down, I will figure out the datastore_delete. Noting that datastore_records_delete is just a wrapper of datastore_delete so all should be fine with that action. Will probably just need to catch ValidationError and spit it out in a Flask response way.

- Outputted foreign keys to datastore_info. - Handled constraint errors in delete. - Changed delete table from CASCADE to RESTRICT.

- More foreign key stuffs.

ckanext/datastore/backend/postgres.py

- Added GET request to DS Info.

- Add drop to existing foreign keys of none or new ones are provided. - Removed incomplete info from datastore_info for foreign key outputs. - Explicitly set on update to restrict for foreign key constraints.

- Attempting fix for our JS/jQuery versions.

- Minor fixes for our setup of jquery versions.

- Added more change log files.

ckanext/datastore/logic/action.py

- Allow passing database connections into datastore upsert to allow deferring commits and closing connections.

- FIXME markdown a11y tags.

…ature/ds-foreign-keys

- Disallow headings. - Disallow images.

feat(logic): ds foreign keys;

ba377e4

- Started working on fereign key constraints for the datastore.

JVickery-TBS added the enhancement label Aug 16, 2024

JVickery-TBS requested a review from wardi August 16, 2024 20:14

JVickery-TBS assigned wardi and JVickery-TBS Aug 16, 2024

wardi reviewed Aug 16, 2024

View reviewed changes

ckanext/datastore/backend/postgres.py Outdated Show resolved Hide resolved

feat(logic): ds foreign keys;

f1f1f51

- Continued working on fereign key constraints for the datastore.

JVickery-TBS added 2 commits August 20, 2024 19:32

feat(logic): ds foreign keys;

7e02e60

- Outputted foreign keys to datastore_info. - Handled constraint errors in delete. - Changed delete table from CASCADE to RESTRICT.

feat(logic): ds foreign keys;

346642b

- More foreign key stuffs.