Skip to content

Deployer Maturity: RGD Deletion #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
10 tasks
frewilhelm opened this issue Apr 25, 2025 · 0 comments
Open
10 tasks

Deployer Maturity: RGD Deletion #194

frewilhelm opened this issue Apr 25, 2025 · 0 comments
Assignees
Labels
kind/task small task, normally part of feature or epic
Milestone

Comments

@frewilhelm
Copy link
Contributor

frewilhelm commented Apr 25, 2025

Description

#172 introduces a basic implementation of a deployer using kro.

The new deployer will only CreateOrUpdate the passed RGDs.

However, if the resource containing the RGD is updated with the same RGD but a different RGD name, the current/applied RGD must be deleted before the new one is applied.

If the applied RGD is not deleted, it will still be reconciled but nothing will happen with that RGD as the name differs from the RGD from the resource.

TODOs:

  • Check if there are already RGDs deployed in the cluster that are referenced by the controller
    • If so, check if the name differs
      • If so, delete the applied RGD
      • If not, update the applied RGD
    • If not, create the RGD

The above described behaviour is not ideal, but a first iteration step to a mature deployer. The ideal behaviour will be implemented by #196.

Done Criteria

  • Code has been reviewed by other team members
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Integration Test Suite updated (includes deletion of existing unnecessary Integration Test and/or creation of new ones if required)
  • Successful demonstration in Review
@frewilhelm frewilhelm added kind/task small task, normally part of feature or epic needs/refinement Discuss with the team and gain a shared understanding needs/validation Validate the issue and assign a priority labels Apr 25, 2025
@frewilhelm frewilhelm self-assigned this Apr 25, 2025
@jakobmoellerdev jakobmoellerdev removed the needs/validation Validate the issue and assign a priority label Apr 28, 2025
@jakobmoellerdev jakobmoellerdev moved this from 🆕 ToDo to 📋 Next-UP in OCM Backlog Board Apr 28, 2025
@hilmarf hilmarf removed the needs/refinement Discuss with the team and gain a shared understanding label Apr 30, 2025
@hilmarf hilmarf added this to the 2025-Q2 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task small task, normally part of feature or epic
Projects
Status: 📋 Next-UP
Development

No branches or pull requests

3 participants