Skip to content

Provide and implement authentication for source registry (and internal registry if necessary) #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks
frewilhelm opened this issue Apr 1, 2025 · 2 comments
Labels
kind/task small task, normally part of feature or epic
Milestone

Comments

@frewilhelm
Copy link
Contributor

Description
The storage migration implementation #98 does not use credentials to authenticate against a source registry when copying resources of type OCI artifact in the resource controller.

If we go along with the storage migration (which is debatable see #164), then we either need to use OCM to copy the resources from one registry to another or provide the secrets for authentication using ocm and then pass them to enable oras copy.

Done Criteria

  • Check if necessary (Implement a Deployer #146)
  • Code has been reviewed by other team members
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Enduser Documentation updated (if applicable)
  • Internal technical Documentation created/updated (if applicable)
  • Successful demonstration in Review
@frewilhelm frewilhelm added kind/task small task, normally part of feature or epic needs/refinement Discuss with the team and gain a shared understanding needs/validation Validate the issue and assign a priority labels Apr 1, 2025
@fabianburth
Copy link
Contributor

Postponed until deployment ADR is merged.

@fabianburth
Copy link
Contributor

We decided to pursue the KRO approach. Therefore, we do not need the ORAS copy method call anymore, which was currently unauthenticated. Thus, this issue is obsolete.

@github-project-automation github-project-automation bot moved this from 🆕 ToDo to 🍺 Done in OCM Backlog Board Apr 24, 2025
@ocmbot ocmbot bot added this to the 2025-Q2 milestone Apr 24, 2025
@frewilhelm frewilhelm removed needs/validation Validate the issue and assign a priority needs/refinement Discuss with the team and gain a shared understanding labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task small task, normally part of feature or epic
Projects
Status: 🍺 Done
Development

No branches or pull requests

2 participants