Skip to content

Refactor api/v1alpha1/condition_types.go #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks
frewilhelm opened this issue Mar 28, 2025 · 1 comment
Closed
4 tasks

Refactor api/v1alpha1/condition_types.go #169

frewilhelm opened this issue Mar 28, 2025 · 1 comment
Labels
kind/task small task, normally part of feature or epic
Milestone
2025-Q2

Comments

@frewilhelm
Copy link
Contributor

Description

Currently, we have about 27 different reasons for technical failures in our controllers. #98 will introduce even more.

While those condition_types can be beneficial in some cases, the current ones are clearly an overkill, must be reduced, and refactored.

Please take a look which condition types are useful and remove/adjust the remaining ones.

Done Criteria

  • Code has been reviewed by other team members
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Successful demonstration in Review
@frewilhelm frewilhelm added kind/task small task, normally part of feature or epic needs/refinement Discuss with the team and gain a shared understanding needs/validation Validate the issue and assign a priority labels Mar 28, 2025
@frewilhelm frewilhelm mentioned this issue Mar 28, 2025
Merged
@ikhandamirov ikhandamirov removed needs/validation Validate the issue and assign a priority needs/refinement Discuss with the team and gain a shared understanding labels Apr 3, 2025
@frewilhelm
Copy link
Contributor Author

Will be done by #172

@github-project-automation github-project-automation bot moved this from 🆕 ToDo to 🍺 Done in OCM Backlog Board Apr 25, 2025
@ocmbot ocmbot bot added this to the 2025-Q2 milestone Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task small task, normally part of feature or epic
Projects
OCM Backlog Board
Status: 🍺 Done
Milestone
2025-Q2
Development

No branches or pull requests
2 participants
@frewilhelm @ikhandamirov