Skip to content

Which tag should be used for the OCI artifact of a configured resource? #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
frewilhelm opened this issue Mar 19, 2025 · 1 comment
Closed
2 tasks
Labels
kind/task small task, normally part of feature or epic needs/validation Validate the issue and assign a priority
Milestone

Comments

@frewilhelm
Copy link
Contributor

frewilhelm commented Mar 19, 2025

Description

Currently, it is unclear which tag a single layer OCI artifact, created by the configuration controller, should be tagged with.

Possible options:

  • Tag of the target resource, so the configuredResource (not implemented)
  • Tag of the source resource, so the resource (not implemented)
  • Extra tag passed through annotations or the like

At the moment there is no way to pass the tag from the target or source resource to the configuration-controller. This would require some adjustments of the API or the content interface.

Additionally, one has to consider how to handle for example HelmCharts in OCI Artifacts that should be tagged with the HelmChart version again to be consumed by e.g. FluxCDs OCIRepository and HelmRelease.

Especially the last aspect is also relevant for the deployer, since the deployer could do some workarounds to provide meaningful tags. That is why this is a sub-task of the deployer

Done Criteria

  • The single layer OCI artifact is tagged with a meaningful tag
  • The e2e-tests are running with a localized and/or configured resource
@frewilhelm frewilhelm added kind/task small task, normally part of feature or epic needs/validation Validate the issue and assign a priority labels Mar 19, 2025
@jakobmoellerdev
Copy link
Contributor

This is a design question that should be answered in the Deployer ADR (#136) and not be a separate issue.

To the question: The tag of the configured and origin resource tag should align semantically. I think one could use the dns name for the tag, or even another differentiator.

Closing as such until discussed further in the ADR

@github-project-automation github-project-automation bot moved this from 🆕 ToDo to 🍺 Done in OCM Backlog Board Mar 20, 2025
@ocmbot ocmbot bot added this to the 2025-Q1 milestone Mar 20, 2025
@ocmbot ocmbot bot moved this from 🍺 Done to 🔒Closed in OCM Backlog Board Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task small task, normally part of feature or epic needs/validation Validate the issue and assign a priority
Projects
Status: 🔒Closed
Development

No branches or pull requests

2 participants