Skip to content

Commit 347e3cd

Browse files
authored
cleanup(buildtool): disable unit tests when building tor (#1368)
We're building unit tests for no reason. Also, unit tests do not build for iOS. So, let's stop building them. Part of ooni/probe#2564
1 parent 76c140f commit 347e3cd

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

internal/cmd/buildtool/android_test.go

+4
Original file line numberDiff line numberDiff line change
@@ -1701,6 +1701,7 @@ func TestAndroidBuildCdepsTor(t *testing.T) {
17011701
"--disable-tool-name-check",
17021702
"--disable-systemd",
17031703
"--prefix=/",
1704+
"--disable-unittests",
17041705
},
17051706
}, {
17061707
Env: []string{},
@@ -1777,6 +1778,7 @@ func TestAndroidBuildCdepsTor(t *testing.T) {
17771778
"--disable-tool-name-check",
17781779
"--disable-systemd",
17791780
"--prefix=/",
1781+
"--disable-unittests",
17801782
},
17811783
}, {
17821784
Env: []string{},
@@ -1853,6 +1855,7 @@ func TestAndroidBuildCdepsTor(t *testing.T) {
18531855
"--disable-tool-name-check",
18541856
"--disable-systemd",
18551857
"--prefix=/",
1858+
"--disable-unittests",
18561859
},
18571860
}, {
18581861
Env: []string{},
@@ -1929,6 +1932,7 @@ func TestAndroidBuildCdepsTor(t *testing.T) {
19291932
"--disable-tool-name-check",
19301933
"--disable-systemd",
19311934
"--prefix=/",
1935+
"--disable-unittests",
19321936
},
19331937
}, {
19341938
Env: []string{},

internal/cmd/buildtool/cdepstor.go

+1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ func cdepsTorBuildMain(globalEnv *cBuildEnv, deps buildtoolmodel.Dependencies) {
5656
"--disable-tool-name-check",
5757
"--disable-systemd",
5858
"--prefix=/",
59+
"--disable-unittests",
5960
)
6061
runtimex.Try0(shellx.RunEx(defaultShellxConfig(), argv, envp))
6162

internal/cmd/buildtool/linuxcdeps_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,7 @@ func TestLinuxCdepsBuildMain(t *testing.T) {
346346
"--disable-tool-name-check",
347347
"--disable-systemd",
348348
"--prefix=/",
349+
"--disable-unittests",
349350
},
350351
}, {
351352
Env: []string{},

0 commit comments

Comments
 (0)