Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer feature/stream-mode branch in fxamacker/cbor #539

Open
fxamacker opened this issue Mar 19, 2025 · 1 comment · May be fixed by #542
Open

Update to newer feature/stream-mode branch in fxamacker/cbor #539

fxamacker opened this issue Mar 19, 2025 · 1 comment · May be fixed by #542
Assignees
Labels
enhancement New feature or request

Comments

@fxamacker
Copy link
Member

fxamacker commented Mar 19, 2025

Currently, fxamacker/cbor's feature/stream-mode branch is still based on v2.4.

After updating fxamacker'cbor's feature/stream-mode branch to be based on v2.7, I will update atree to use it.

This requires fuzz testing fxamacker/cbor's feature branch, smoke testing atree, and making sure this change doesn't break onflow/cadence, onflow/flow-go, etc.

NOTE: Eventually, I will add stream mode to the main branch of fxamacker/cbor along with some improvements.

@fxamacker fxamacker added the enhancement New feature or request label Mar 19, 2025
@fxamacker fxamacker self-assigned this Mar 19, 2025
@fxamacker fxamacker changed the title Update feature/stream-mode branch Update to newer feature/stream-mode branch in fxamacker/cbor Mar 19, 2025
@fxamacker fxamacker linked a pull request Mar 19, 2025 that will close this issue
6 tasks
@fxamacker
Copy link
Member Author

fxamacker commented Mar 19, 2025

As mentioned in PR #542, we should make sure various tests pass before merging any PRs to main branch:

  • longer duration smoke testing
  • backward compatibility tests using testnet blocks
  • backward compatibility tests using mainnet blocks
  • integration tests in other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant