Skip to content

cleanup CMAKE lib vars #1186

Open
Open
@bratpiorka

Description

@bratpiorka

Today we define set of lib-related CMAKE vars like:

-- Will fetch jemalloc from https://github.com/jemalloc/jemalloc.git (tag: 5.3.0)
--     JEMALLOC_LIBRARIES = /home/rrudnick/unified-memory-framework/build/_deps/jemalloc_targ-build/lib/libjemalloc.a
--     JEMALLOC_INCLUDE_DIRS = /home/rrudnick/unified-memory-framework/build/_deps/jemalloc_targ-build/include
--     JEMALLOC_LIBRARY_DIRS = /home/rrudnick/unified-memory-framework/build/_deps/jemalloc_targ-build/lib

the problem is that we mix *_LIBRARIES with *_LIBRARY_DIRS - we should have full path defined only in *_LIBRARY_DIRS.
Additionally, all vars defined in UMF should have an "UMF" prefix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions