Merge pull request #1373 from lplewa/strcpy

add missing \0 in case of strcpy() too long string

Author: lukaszstolarczuk

src/pool/pool_disjoint.c

@@ -45,7 +45,10 @@ static int CTL_READ_HANDLER(name)(void *ctx, umf_ctl_query_source_t source,
         return -1;
     }
 
-    strncpy((char *)arg, pool->params.name, size);
+    if (size > 0) {
+        strncpy((char *)arg, pool->params.name, size - 1);
+        ((char *)arg)[size - 1] = '\0';
+    }
     return 0;
 }
 
@@ -63,6 +66,7 @@ static int CTL_WRITE_HANDLER(name)(void *ctx, umf_ctl_query_source_t source,
     }
 
     strncpy(pool->params.name, (char *)arg, sizeof(pool->params.name) - 1);
+    pool->params.name[sizeof(pool->params.name) - 1] = '\0';
     return 0;
 }
 
@@ -1089,6 +1093,7 @@ umfDisjointPoolParamsCreate(umf_disjoint_pool_params_handle_t *hParams) {
     };
 
     strncpy(params->name, DEFAULT_NAME, sizeof(params->name) - 1);
+    params->name[sizeof(params->name) - 1] = '\0';
 
     *hParams = params;
     return UMF_RESULT_SUCCESS;
@@ -1190,5 +1195,6 @@ umfDisjointPoolParamsSetName(umf_disjoint_pool_params_handle_t hParams,
     }
 
     strncpy(hParams->name, name, sizeof(hParams->name) - 1);
+    hParams->name[sizeof(hParams->name) - 1] = '\0';
     return UMF_RESULT_SUCCESS;
 }

src/provider/provider_cuda.c

@@ -530,9 +530,11 @@ static void cu_memory_provider_get_last_native_error(void *provider,
     if (result == CUDA_SUCCESS && error_name != NULL) {
         strncpy(TLS_last_native_error.msg_buff, error_name,
                 TLS_MSG_BUF_LEN - 1);
+        TLS_last_native_error.msg_buff[TLS_MSG_BUF_LEN - 1] = '\0';
     } else {
         strncpy(TLS_last_native_error.msg_buff, "cuGetErrorName() failed",
                 TLS_MSG_BUF_LEN - 1);
+        TLS_last_native_error.msg_buff[TLS_MSG_BUF_LEN - 1] = '\0';
     }
 
     buf_size = strlen(TLS_last_native_error.msg_buff);