Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more database options #1

Open
omwah opened this issue May 26, 2013 · 10 comments
Open

Add more database options #1

omwah opened this issue May 26, 2013 · 10 comments
Assignees

Comments

@omwah
Copy link
Owner

omwah commented May 26, 2013

Add support for SQLite and MySQL storage options.

@odensc
Copy link
Contributor

odensc commented Jun 24, 2014

Would there be any performance difference from SQLite vs. YAML?

@omwah
Copy link
Owner Author

omwah commented Jun 25, 2014

Probably not considering that the economy is not really being hit very often. Maybe it would matter if someone was getting constant updates to their balance.

@RiflemanSD
Copy link
Collaborator

Hello @omwah .

This plugin is very nice. But there is a problem.
You are using only YAML for storing data, and that make a lot of lag when the yaml is big!
You must add SQL support.

And if u want, i can help you, i am creating a SQLite small lib now, and i can add it to your source, to support a SQLite storage.

@omwah
Copy link
Owner Author

omwah commented Feb 26, 2015

Feel free to implement it and issue a pull request. If you want to become a maintainer then let me know. The other guys who mentioned working on the plugin seem to have gone inactive, at least on SDFEconomy.

@odensc
Copy link
Contributor

odensc commented Feb 26, 2015

@omwah Ah, I don't develop for Minecraft anymore. You can remove me as a collaborator.

@omwah
Copy link
Owner Author

omwah commented Feb 26, 2015

@TheSBros Same here! No problem of having moved on, I have as well.

@RiflemanSD
Copy link
Collaborator

@omwah Yeah, i would like to be a maintainer of this project ! I have notice there are some improvements can be done here.
Also, i will do the pull request, after finish the lib and testing it.
Thanks !

@omwah
Copy link
Owner Author

omwah commented Feb 27, 2015

Don't worry about a pull request, I just gave you commit privileges. You can commit directly.

@RiflemanSD
Copy link
Collaborator

@omwah Just to know, i had a problem with SQLite library, i am trying to fix it. But because i have a work that days, maybe i will late a little.
I will give you more info soon.

@omwah
Copy link
Owner Author

omwah commented Mar 4, 2015

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants