Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: allowing httpx version 0.28 #356

Open
jamesbraza opened this issue Dec 2, 2024 · 3 comments
Open

Request: allowing httpx version 0.28 #356

jamesbraza opened this issue Dec 2, 2024 · 3 comments
Assignees

Comments

@jamesbraza
Copy link

https://github.com/encode/httpx/releases/tag/0.28.0 comes with some breaking changes, mainly on httpx.AsyncClient's app argument.

Trying to pull it in, I get blocked by ollama because it downpins httpx: https://github.com/ollama/ollama-python/blob/v0.4.2/pyproject.toml#L13

Can we move httpx = "^0.27.0" to httpx = ">=0.27"

@ParthSareen
Copy link
Contributor

Hey @jamesbraza, thanks for bringing this up - we pin the version to not have unintended updates (like even the one you've mentioned) Will check this out a bit more bump the version!

@simonaubertbd
Copy link

Hello @jamesbraza It also means some incompatibility with jupyterlab as well.

@jedahan
Copy link

jedahan commented Dec 18, 2024

breaks llm-ollama plugin install as well, due to conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants