fabtests/efa: BUG: efa_gda: recv buffer verification is skipped silently #11538
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: efa_gda fabtest had a logical bug. When verifying rx_buf contents, we checked if both `FT_OPT_VERIFY_DATA` and `FT_OPT_ACTIVE` options were set. However, `FT_OPT_ACTIVE` is unset by `ft_stop()`, which is called in the main loop to check for timeout. Fix: Check only for `FT_OPT_VERIFY_DATA` option. Signed-off-by: Alexey Novikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
efa_gda fabtest had a logical bug. When verifying rx_buf contents, we checked if both
FT_OPT_VERIFY_DATAandFT_OPT_ACTIVEoptions were set. However,FT_OPT_ACTIVEis unset byft_stop(), which is called in the main loop to check for timeout.Fix:
Check only for
FT_OPT_VERIFY_DATAoption.