random comments

Author: taki-odoo

.idea/.gitignore

@@ -1 +1 @@
-from . import models
+from . import models

.idea/inspectionProfiles/profiles_settings.xml

@@ -1,5 +1,5 @@
 {
-    'name': 'Estate',
+    'name': "Estate",
     'depends': ['base'],
     'application': True,
     'installable': True,

.idea/misc.xml

@@ -1,10 +1,18 @@
-from odoo import fields, models
 from datetime import date, timedelta
 
+from odoo import api, fields, models
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare, float_is_zero
+
 class EstateProperty(models.Model):
-    _name = "estate.property"
+    _name = 'estate.property'
     _description = "Real Estate Property"
 
+    _sql_constraints = [
+        ('check_expected_price', 'CHECK(expected_price > 0)', "Expected price must be strictly positive."),
+        ('check_selling_price', 'CHECK(selling_price >= 0)', "Selling price must be strictly positive.")
+    ]
+
     name = fields.Char(string="Title", required=True)
     description = fields.Text()
     postcode = fields.Char()
@@ -13,30 +21,89 @@ class EstateProperty(models.Model):
     selling_price = fields.Float(readonly=True, copy=False)
     bedrooms = fields.Integer(default=2)
     living_area = fields.Integer(string="Living Area (sqm)")
-    facades = fields.Integer()
+    facades = fields.Integer(string="Facade")
     garage = fields.Boolean()
     garden = fields.Boolean()
-    garden_area = fields.Integer()
+    garden_area = fields.Integer(string="Garden Area (sqm)")
     garden_orientation = fields.Selection(
         selection=[
-            ('north', 'North'),
-            ('south', 'South'),
-            ('east', 'East'),
-            ('west', 'West'),
+            ('north', "North"),
+            ('south', "South"),
+            ('east', "East"),
+            ('west', "West"),
         ],
         string="Garden Orientation"
     )
     available = fields.Boolean(default=True)
-    property_type = fields.Many2one("estate.property.type", string="Property Type")
-    property_salesman = fields.Many2one("res.users", string="Salesman", default=lambda self: self.env.user)
-    property_buyer = fields.Many2one("res.partner", string="Buyer");
-    property_tags = fields.Many2many("estate.property.tag", string="Tags")
-    property_offers = fields.One2many("estate.property.offer", "property_id", string="Offers")
+    property_type_id = fields.Many2one("estate.property.type", string="Property Type")
+    salesman_id = fields.Many2one("res.users", string="Salesman", default=lambda self: self.env.user)
+    buyer_id = fields.Many2one("res.partner", string="Buyer")
+    tag_ids = fields.Many2many("estate.property.tag", string="Tags")
+    offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
     state = fields.Selection(
-        selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'),
-                   ('sold', 'Sold'), ('cancelled', 'Cancelled')],
+        selection=[
+            ('new', "New"),
+            ('offer_received', "Received"),
+            ('offer_accepted', "Accepted"),
+            ('sold', "Sold"),
+            ('cancelled', "Cancelled"),
+            ('refused', "Refused")
+        ],
         required=True,
         copy=False,
         default='new'
     )
-    note = fields.Text("Special mention about the property.")
+    note = fields.Text(string="Special mention about the property.")
+    total_area = fields.Integer(string="Total Area (sqm)", compute="_compute_total_area")
+    best_offer = fields.Float(string="Best Offer", compute="_compute_best_price")
+
+    @api.depends("living_area", "garden_area")
+    def _compute_total_area(self):
+        for record in self:
+            record.total_area = record.living_area + record.garden_area
+
+    @api.depends("offer_ids.price")
+    def _compute_best_price(self):
+        for record in self:
+            if record.offer_ids:
+                record.best_offer = max(record.offer_ids.mapped("price"))
+            else:
+                record.best_offer = 0.0
+
+    @api.onchange("garden")
+    def _onchange_garden(self):
+        if self.garden:
+            self.garden_area = 10
+            self.garden_orientation = 'north'
+        else:
+            self.garden_area = 0
+            self.garden_orientation = None
+
+    def cancel_property_button(self):
+        for record in self:
+            if record.state != 'sold':
+                record.state = 'cancelled'
+            else:
+                raise UserError("You cannot cancel a sold property.")
+
+    def sold_property_button(self):
+        for record in self:
+            if record.state != 'cancelled':
+                record.state = 'sold'
+            else:
+                raise UserError("You cannot sell a cancelled property.")
+
+    @api.constrains('expected_price')
+    def _check_expected_price_positive(self):
+        for record in self:
+            if record.expected_price <= 0:
+                raise ValidationError("Expected price must be strictly positive.")
+
+    @api.constrains('selling_price', 'expected_price')
+    def _check_selling_price_margin(self):
+        for record in self:
+            if float_is_zero(record.selling_price, precision_digits=2):
+                continue
+            min_acceptable_price = record.expected_price * 0.9
+            if float_compare(record.selling_price, min_acceptable_price, precision_digits=2) < 0:
+                raise ValidationError("The selling price cannot be lower than 90% of the expected price.")

.idea/modules.xml

@@ -1,11 +1,45 @@
-from odoo import fields,models,api
-from dateutil.relativedelta import relativedelta
+from datetime import date, timedelta
 
-class estate_property_offer(models.Model):
+from odoo import api, fields, models
+from odoo.exceptions import UserError
+
+
+class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Estate property offer"
 
     price = fields.Float()
-    status = fields.Selection([('accepted', 'Accepted'), ('refused', 'Refused')], copy=False)
+    status = fields.Selection(
+        selection=[
+            ('accepted', "Accepted"),
+            ('refused', "Refused")
+        ],
+        copy=False
+    )
     partner_id = fields.Many2one("res.partner", required=True)
-    property_id = fields.Many2one("estate.property", required=True)
+    property_id = fields.Many2one("estate.property", required=True)
+    validity = fields.Integer(default=7)
+    deadline = fields.Date(string="Deadline", compute="_compute_deadline", inverse="_inverse_deadline")
+
+    @api.depends("validity")
+    def _compute_deadline(self):
+        for record in self:
+            record.deadline = date.today() + timedelta(days=record.validity)
+
+    def _inverse_deadline(self):
+        for record in self:
+            if record.deadline:
+                record.validity = (record.deadline - date.today()).days
+
+    def offer_accept(self):
+        if 'accepted' in self.mapped("property_id.offer_ids.status"):
+            raise UserError("An offer is already accepted.")
+        for record in self:
+            record.status = 'accepted'
+            record.property_id.state = 'offer_accepted'
+            record.property_id.buyer_id = record.partner_id
+            record.property_id.selling_price = record.price
+
+    def offer_refuse(self):
+        for record in self:
+            record.status = 'refused'