Skip to content

Fuse off feedback error #1317

@xmo-odoo

Description

@xmo-odoo

At one point https://www.githubstatus.com/incidents/lcw3tg2f6zsd resulted in the issues/comments endpoint returning 500 errors but still posting comments. Per the error recovery of that branch, this resulted in the mergebot re-sending the feedback on every cron run, which led to some PRs being spammed with a dozen comments in as many minutes (e.g.).

This is... not ideal. As such there are two possibilities:

  1. immediately fuse off (deactivate) the cron if there's an error sending feedback, under the assumption that this is a very rare event, check the github logs to see how often sending feedback results in an error
  2. or implement some sort of backoff or countdown fuse so that the cron slows down or stops if there are many errors in a short period of time.

In either case, send a notification to the admins to signal that the thing has been disabled.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions