Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many files in .gd/indices -- use a database #106

Closed
vrusinov opened this issue Mar 17, 2015 · 7 comments
Closed

Too many files in .gd/indices -- use a database #106

vrusinov opened this issue Mar 17, 2015 · 7 comments
Assignees
Milestone

Comments

@vrusinov
Copy link

Looks like drive creates a separate index file with some info for every file it pulls/pushes. All of them are being created in single directory .gd/indices.

If drive manages many small files, it quickly becomes not efficient & wasteful. A lot of tools won't work very well with lots of files in single directory. Also, this could be quite wasteful with metadata taking almost as much space as data itself.

I think ideally I'd like to see .gd/indices/ replaced with single (or a few) files. We could for example use sqlite or bdb or one of other embedded databases.

@odeke-em
Copy link
Owner

Yeah but the thing is how do we keep track of conflicts without taking note of the metadata? There was an issue in which the user was not happy because they lost data, even though drive stated it did a naive push and pull -- issue #57. Also the multiple files are there to increase the ability for parallel operations on file. Great suggestion on using a DB!

@odeke-em odeke-em changed the title Too many files in .gd/indices Too many files in .gd/indices -- use a database Jun 18, 2015
@nkabir
Copy link

nkabir commented Jun 28, 2015

@odeke-em
Copy link
Owner

Hello @nkabir thank you for that awesome suggestion, and welcome to drive. I just read the Wikipedia reference you posted as well as just peeked at the project page. This looks a great match for this project. I'll take a better look at it when I get up. Thank you again.

@nkabir
Copy link

nkabir commented Jun 28, 2015

You're welcome! Your work is excellent and very much appreciated!

@odeke-em
Copy link
Owner

odeke-em commented Jul 3, 2015

@nkabir with your awesome suggestion (thank you very much), I've been able to hackup something for saving indices and information to a db. Please see PR #268

@nkabir
Copy link

nkabir commented Jul 3, 2015

Fantastic. I'll give it a try!

@odeke-em
Copy link
Owner

odeke-em commented Jul 4, 2015

Addressed by PR #268. Thank you @vrusinov and @nkabir. Please get the latest code.

@odeke-em odeke-em closed this as completed Jul 4, 2015
@odeke-em odeke-em added this to the v0.2.6 milestone Jul 4, 2015
@odeke-em odeke-em self-assigned this Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants