From b9eb6378fc5bd291b415f957f76b554fa9cebca9 Mon Sep 17 00:00:00 2001 From: oddlama Date: Thu, 19 Dec 2024 14:53:14 +0100 Subject: [PATCH] fix: withType has different behavior in 1.21.3+ and refuses to replace air. GG minecraft. --- vane-core/src/main/java/org/oddlama/vane/util/ItemUtil.java | 6 +++++- .../main/java/org/oddlama/vane/portals/menu/StyleMenu.java | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/vane-core/src/main/java/org/oddlama/vane/util/ItemUtil.java b/vane-core/src/main/java/org/oddlama/vane/util/ItemUtil.java index 4b8bd5d4..cff2d5d8 100644 --- a/vane-core/src/main/java/org/oddlama/vane/util/ItemUtil.java +++ b/vane-core/src/main/java/org/oddlama/vane/util/ItemUtil.java @@ -101,7 +101,11 @@ public static ItemStack set_lore(final ItemStack item, final List lor } public static ItemStack name_item(final ItemStack item, Component name, final List lore) { - final var meta = item.getItemMeta(); + var meta = item.getItemMeta(); + if (meta == null) { + // Cannot name item without meta (probably air) + return item; + } name = name.decoration(TextDecoration.ITALIC, false); meta.displayName(name); diff --git a/vane-portals/src/main/java/org/oddlama/vane/portals/menu/StyleMenu.java b/vane-portals/src/main/java/org/oddlama/vane/portals/menu/StyleMenu.java index 8228026c..a7d92be7 100644 --- a/vane-portals/src/main/java/org/oddlama/vane/portals/menu/StyleMenu.java +++ b/vane-portals/src/main/java/org/oddlama/vane/portals/menu/StyleMenu.java @@ -539,7 +539,7 @@ private MenuWidget menu_item_block_selector( public void item(final ItemStack item) { var stack = item_for_type(style_container, active, type); if (stack.getType() == Material.AIR) { - stack = stack.withType(Material.BARRIER); + stack = new ItemStack(Material.BARRIER); } super.item(t_item.alternative(stack, "ยง6" + building_material.getKey())); }