Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we add completed approval details to the status message #340

Open
mohan-the-octocat opened this issue Sep 22, 2022 · 1 comment
Open

Comments

@mohan-the-octocat
Copy link
Contributor

mohan-the-octocat commented Sep 22, 2022

What

The PR Gatekeeper's Status job prints the list of pending approvals, and the corresponding approvers/ groups

But

For the end-user, its would be useful if they can get info on who have already provided the approvals along with the above info

And

It would be nice if as part of the PR Gatekeeper's Status output, we print the current state of the approvals when the status check fails!

Group Approval-status Approver Eligible Approvers
application-development ✅ Complete yuichielectric yuichielectric, mohan-the-octocat
security-team ⏳ Pending rohitnb
infra-team ⌛ Pending dchomh, affrae
@mohan-the-octocat mohan-the-octocat changed the title Can we make the status message more complete Can we add completed approval details to the status message Sep 22, 2022
@yuichielectric
Copy link
Contributor

@mohan-the-octocat I'm working on this on branch job-summary. I'll share here once I will have something you can try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants