Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "Bring your own GitHub App" #738

Open
MariusStorhaug opened this issue Feb 6, 2025 · 3 comments
Open

Add support for "Bring your own GitHub App" #738

MariusStorhaug opened this issue Feb 6, 2025 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@MariusStorhaug
Copy link

MariusStorhaug commented Feb 6, 2025

As a team maintaining the Octo STS I want the ability to use my own GitHub App for the STS service. I do not want to give a third party standing permissions on my organizations, where they can create a installation access token and access my organizations without mitigations.

Solution:

  • Add variables in the setup of the OCTO STS service, selecting ClientID and PEM that it will use.
  • Provide a GitHub App manifest so that team can create an install their own app following OCTO-STS best practice. Create app with manifest flow. The Principal on Minimalism + Security at work ;)
@MariusStorhaug
Copy link
Author

Think I might have misunderstood. This is not a "run it yourself" repo?

@cpanato
Copy link
Collaborator

cpanato commented Feb 7, 2025

did not get your follow up comment

@cpanato cpanato added the documentation Improvements or additions to documentation label Feb 7, 2025
@MariusStorhaug
Copy link
Author

I might be incorrectly assuming the intent with open-sourcing the solution. Do you intend organizations to run this them-selves on their own deploys infra using the TF config you have or is the intention to just calm down users of your company's service?

If the intent is the latter, then thats a sad story for enterprises on GHEC DR (domain.ghe.com). If the intent is that we can deploy what you have shared here, we would like to be able to have some docs on how it works in a bit more detail, how to start setting it up, i.e. where do we specify our own GitHub App (instead of installing your app).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants