From 7ded376e05af8d165f74b5778fcc91d8137871bf Mon Sep 17 00:00:00 2001 From: Sylvain Boilard Date: Thu, 31 Oct 2024 17:23:55 +0100 Subject: [PATCH] Add `name` and `ontoggle` attributes for `details` HTML elements. See: - https://html.spec.whatwg.org/multipage/interactive-elements.html#the-details-element ; - https://html.spec.whatwg.org/multipage/indices.html#event-toggle ; - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#attributes ; - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#events . --- CHANGES.md | 4 ++++ lib/html_f.ml | 1 + lib/html_sigs.mli | 1 + lib/html_types.mli | 2 +- 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 74ecef559..a38940476 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -3,6 +3,10 @@ * Add support for the clip-path presentation attribute (#333 by Martin @MBodin Bodin) +* Add support for the `name` attribute and `toggle` event on + `
` elements + (#341 by @SylvainBoilard) + # 4.6.0 * Update for OCaml 5.0 and drop support for OCaml 4.2.0 diff --git a/lib/html_f.ml b/lib/html_f.ml index 4e1484f99..8eb93b48d 100644 --- a/lib/html_f.ml +++ b/lib/html_f.ml @@ -151,6 +151,7 @@ struct let a_onsubmit = Xml.event_handler_attrib "onsubmit" let a_onsuspend = Xml.event_handler_attrib "onsuspend" let a_ontimeupdate = Xml.event_handler_attrib "ontimeupdate" + let a_ontoggle = Xml.event_handler_attrib "ontoggle" let a_onundo = Xml.event_handler_attrib "onundo" let a_onunload = Xml.event_handler_attrib "onunload" let a_onvolumechange = Xml.event_handler_attrib "onvolumechange" diff --git a/lib/html_sigs.mli b/lib/html_sigs.mli index 1cf169c8f..82357225d 100644 --- a/lib/html_sigs.mli +++ b/lib/html_sigs.mli @@ -215,6 +215,7 @@ module type T = sig val a_onsubmit : Xml.event_handler -> [> | `OnSubmit] attrib val a_onsuspend : Xml.event_handler -> [> | `OnSuspend] attrib val a_ontimeupdate : Xml.event_handler -> [> | `OnTimeUpdate] attrib + val a_ontoggle : Xml.event_handler -> [> | `OnToggle] attrib val a_onundo : Xml.event_handler -> [> | `OnUndo] attrib val a_onunload : Xml.event_handler -> [> | `OnUnload] attrib val a_onvolumechange : Xml.event_handler -> [> | `OnVolumeChange] attrib diff --git a/lib/html_types.mli b/lib/html_types.mli index 7ccd3d3cc..07d5bb557 100644 --- a/lib/html_types.mli +++ b/lib/html_types.mli @@ -2233,7 +2233,7 @@ type details_content = [ | flow5 ] type details_content_fun = [ | flow5 ] -type details_attrib = [ | common | `Open ] +type details_attrib = [ | common | `Open | `Name | `OnToggle ] (* NAME: summary, KIND: star, TYPE: [= common ],[= phrasing ], [=`Summary], ARG: [= phrasing ], ATTRIB: OUT: [=`Summary] *) type summary = [ | `Summary ]