Skip to content

Commit 6f67ac7

Browse files
committed
Do more aggressive lambda lifting
With @vouillon we realized that the `Lambda_lifting_simple` pass that is performed by double translation makes some programs significantly faster. We measured roughly a 1.45 speedup on a large (proprietary) Bonsai benchmark. Presumably V8 is much faster with more toplevel functions and less nested closures.
1 parent 3d8e70d commit 6f67ac7

File tree

1 file changed

+28
-1
lines changed

1 file changed

+28
-1
lines changed

compiler/lib/driver.ml

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,6 +678,33 @@ let link_and_pack ?(standalone = true) ?(wrap_with_fun = `Iife) ?(link = `No) p
678678
|> coloring
679679
|> check_js
680680

681+
let all_functions p =
682+
let open Code in
683+
fold_closures
684+
p
685+
(fun name _ _ acc ->
686+
match name with
687+
| Some name -> Var.Set.add name acc
688+
| None -> acc)
689+
Var.Set.empty
690+
691+
let effects_or_lambda_lift ~deadcode_sentinal p =
692+
(* If effects are disabled, we lambda-lift aggressively. While not necessary, it results
693+
in a substantial gain in performance for Javascript. *)
694+
match Config.(target (), effects ()) with
695+
| `JavaScript, `Disabled ->
696+
let to_lift = all_functions p in
697+
let p, _ = Lambda_lifting_simple.f ~to_lift p in
698+
( p
699+
, (Code.Var.Set.empty : Effects.trampolined_calls)
700+
, (Code.Var.Set.empty : Effects.in_cps) )
701+
| _, (`Cps | `Double_translation) -> effects ~deadcode_sentinal p
702+
| `Wasm, (`Disabled | `Jspi) ->
703+
( p
704+
, (Code.Var.Set.empty : Effects.trampolined_calls)
705+
, (Code.Var.Set.empty : Effects.in_cps) )
706+
| `JavaScript, `Jspi -> assert false
707+
681708
let optimize ~profile p =
682709
let deadcode_sentinal =
683710
(* If deadcode is disabled, this field is just fresh variable *)
@@ -690,7 +717,7 @@ let optimize ~profile p =
690717
| O2 -> o2
691718
| O3 -> o3)
692719
+> exact_calls ~deadcode_sentinal profile
693-
+> effects ~deadcode_sentinal
720+
+> effects_or_lambda_lift ~deadcode_sentinal
694721
+> map_fst
695722
(match Config.target (), Config.effects () with
696723
| `JavaScript, `Disabled -> Generate_closure.f

0 commit comments

Comments
 (0)