From 943dffeb2535176cc24e25faf92121d65e23abd1 Mon Sep 17 00:00:00 2001
From: Punith Kenchappa <pkenchap@redhat.com>
Date: Mon, 20 May 2024 18:30:29 +0530
Subject: [PATCH 1/2] Added tfvars and readme file

Signed-off-by: Punith Kenchappa <pkenchap@redhat.com>
---
 tf/add-powervm-workers/README.md      | 43 +++++++++++++++++++++++++++
 tf/add-powervm-workers/powervm.tfvars | 20 +++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 tf/add-powervm-workers/README.md
 create mode 100644 tf/add-powervm-workers/powervm.tfvars

diff --git a/tf/add-powervm-workers/README.md b/tf/add-powervm-workers/README.md
new file mode 100644
index 0000000..d0a3ce6
--- /dev/null
+++ b/tf/add-powervm-workers/README.md
@@ -0,0 +1,43 @@
+# Add PowerVM workers to Intel cluster
+
+User need to uopdate required vales in data/vars.tfvars file such as username and password of IBM intranet credentials to get access to the PowerVC.
+```
+auth_url                    = "https://scnlonprema.pokprv.stglabs.ibm.com:5000/v3/"
+user_name                   = "***@us.ibm.com"
+password                    = "***"
+```
+
+### Use Terraform command to plan and apply .
+
+  ```
+  terraform plan -var-file=data/vars.tfvars
+  ```
+
+  ```
+  terraform apply -var-file=data/vars.tfvars
+  ```
+
+### Configure the DHCP and restart the dhcpd service.
+
+Get the MAC Address and IP Address of the VM created on PowerVC. Update /etc/dhcp/dhcpd.conf with the lease/addresses as shown below.
+
+  ```
+  host workerp-0 { hardware ethernet fa:16:3e:0f:95:6b; fixed-address 10.20.177.243; }
+  ```
+
+* Restart the dhcpd.
+  ```
+  systemctl restart dhcpd
+  ```
+* Restart the Worker node for ignition to start.
+
+* Approve the CSR certificate to add the worker to intel cluster.
+  ```
+  oc get csr
+  ```
+  ```
+  oc adm certificate approve <certificate-name>
+  ```
+
+
+
diff --git a/tf/add-powervm-workers/powervm.tfvars b/tf/add-powervm-workers/powervm.tfvars
new file mode 100644
index 0000000..f559d07
--- /dev/null
+++ b/tf/add-powervm-workers/powervm.tfvars
@@ -0,0 +1,20 @@
+################################################################
+# Copyright 2024 - IBM Corporation. All rights reserved
+# SPDX-License-Identifier: Apache-2.0
+################################################################
+
+auth_url                    = "https://scnlonprema.pokprv.stglabs.ibm.com:5000/v3/"
+user_name                   = "***@us.ibm.com"
+password                    = "***"
+ignition_ip                 = "10.20.29.41"
+resolver_ip                 = "10.20.29.41"
+resolve_domain              = ""
+insecure                    = true
+tenant_name                 = "base-ocp"
+domain_name                 = "Default"
+network_name                = "vlan1337"
+power_worker_prefix         = "power-worker-"
+flavor_id                   = "29fcd15b-c41c-4b9b-90b7-43bbf914c2df"
+image_id                    = "3f877d0e-84e8-41fe-988d-318ea1521b0a"
+openstack_availability_zone = "e980"
+worker_count                = 2

From c4216f3ecbbc8467d215c63d194464d19ccf4080 Mon Sep 17 00:00:00 2001
From: Paul Bastide <paul@bastide.org>
Date: Mon, 20 May 2024 09:11:14 -0400
Subject: [PATCH 2/2] Apply suggestions from code review

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
---
 tf/add-powervm-workers/README.md      |  2 +-
 tf/add-powervm-workers/powervm.tfvars | 33 +++++++++++++++------------
 2 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/tf/add-powervm-workers/README.md b/tf/add-powervm-workers/README.md
index d0a3ce6..53723df 100644
--- a/tf/add-powervm-workers/README.md
+++ b/tf/add-powervm-workers/README.md
@@ -2,7 +2,7 @@
 
 User need to uopdate required vales in data/vars.tfvars file such as username and password of IBM intranet credentials to get access to the PowerVC.
 ```
-auth_url                    = "https://scnlonprema.pokprv.stglabs.ibm.com:5000/v3/"
+auth_url                    = "https://host.net:5000/v3/"
 user_name                   = "***@us.ibm.com"
 password                    = "***"
 ```
diff --git a/tf/add-powervm-workers/powervm.tfvars b/tf/add-powervm-workers/powervm.tfvars
index f559d07..f55a216 100644
--- a/tf/add-powervm-workers/powervm.tfvars
+++ b/tf/add-powervm-workers/powervm.tfvars
@@ -3,18 +3,21 @@
 # SPDX-License-Identifier: Apache-2.0
 ################################################################
 
-auth_url                    = "https://scnlonprema.pokprv.stglabs.ibm.com:5000/v3/"
-user_name                   = "***@us.ibm.com"
-password                    = "***"
-ignition_ip                 = "10.20.29.41"
-resolver_ip                 = "10.20.29.41"
-resolve_domain              = ""
-insecure                    = true
-tenant_name                 = "base-ocp"
-domain_name                 = "Default"
-network_name                = "vlan1337"
-power_worker_prefix         = "power-worker-"
-flavor_id                   = "29fcd15b-c41c-4b9b-90b7-43bbf914c2df"
-image_id                    = "3f877d0e-84e8-41fe-988d-318ea1521b0a"
-openstack_availability_zone = "e980"
-worker_count                = 2
+auth_url    = "https://<PowerVC-Host>:5000/v3/"
+user_name   = "<EMAIL>"
+password    = "<PASSWORD>"
+insecure    = true
+tenant_name = "<PROJECT>"
+domain_name = "<DOMAIN>"
+
+network_name                = "<NETWORK>"
+ignition_ip                 = "<IP>"
+resolver_ip                 = "<IP>"
+resolve_domain              = "<domain for resolver dns>"
+power_worker_prefix         = "<prefix-for-power-workers>"
+flavor_id                   = "<flavor_id>"
+image_id                    = "<image_id>"
+openstack_availability_zone = "<host group>"
+
+# the number of workers to create
+worker_count = 2