Update .golangci.yaml configuration (#40)

* Update .golangci.yaml configuration

* linter fixes

* linter fixes

* linter fixes

Author: occamist

.github/workflows/main.yaml

@@ -2,9 +2,9 @@ name: CI
 
 on:
   push:
-    branches: [ "main" ]
+    branches: ["main"]
   pull_request:
-    branches: [ "main" ]
+    branches: ["main"]
 
 jobs:
   tests:
@@ -16,12 +16,12 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.26.x'
+          go-version: "1.26.x"
 
       - name: Lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.11.3
+          version: v2.12
 
       - name: Test
         run: go test -race -covermode atomic -coverprofile=coverage.txt -v ./...

.golangci.yaml

@@ -13,23 +13,22 @@ linters:
     - errname
     - fatcontext
     - forcetypeassert
-    - gochecknoinits
     - goconst
-    - godox
     - gosec
     - govet
     - ineffassign
-    - interfacebloat
-    - musttag
+    - makezero
+    - modernize
     - nilerr
     - nilnil
     - noctx
     - nolintlint
+    - prealloc
     - predeclared
     - recvcheck
     - revive
     - sloglint
-    - staticcheck # stylecheck, gosimple, and staticcheck has been merged inside the staticcheck
+    - staticcheck
     - thelper
     - tparallel
     - unconvert
@@ -43,19 +42,10 @@ linters:
     goconst:
       min-len: 3
       min-occurrences: 3
-    godox:
-      keywords:
-        - TODO
-        - BUG
-        - FIXME
-        - OPTIMIZE
-        - HACK
-    interfacebloat:
-      max: 5
+      ignore-tests: true
     nolintlint:
-      require-explanation: false
+      require-explanation: true
       require-specific: true
-      allow-unused: false
     revive:
       max-open-files: 2048
       confidence: 0.8
@@ -78,26 +68,15 @@ linters:
           severity: warning
           disabled: false
     usetesting:
-      os-mkdir-temp: true
-      os-setenv: true
-      os-temp-dir: true
-      os-create-temp: true
+      context-background: true
+      context-todo: true
   exclusions:
     generated: lax
     rules:
-      - linters:
-          - containedctx
-          - goconst
-        path: (.+)_test\.go
-
       - linters:
           - revive
         path: synthesize/voice.go
         text: "exported const .* should have comment"
-    paths:
-      - third_party$
-      - builtin$
-      - examples$
 formatters:
   enable:
     - gci
@@ -111,9 +90,3 @@ formatters:
         - default
         - prefix(github.com/occamist/laverna)
       custom-order: true
-  exclusions:
-    generated: lax
-    paths:
-      - third_party$
-      - builtin$
-      - examples$

synthesize/runner_test.go

@@ -23,7 +23,7 @@ func TestBatchRunner(t *testing.T) {
 		saveFn     func(string, []byte) error
 		wantErr    error
 		wantAudios []string
-		ctx        context.Context
+		ctx        context.Context //nolint:containedctx // one test requires a cancelled context
 	}{
 		{
 			name: "successful batch run",

synthesize/voice_test.go

@@ -85,7 +85,7 @@ func TestRun_AllVoices(t *testing.T) {
 		opt     Opt
 		wantErr error
 	}
-	var tests []Test
+	tests := make([]Test, 0, len(testVoices))
 
 	for _, voice := range testVoices {
 		opt := Opt{