Skip to content

[ocaml5-issue] Segfault on s390x in Effect test #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmid opened this issue Aug 17, 2023 · 2 comments
Closed

[ocaml5-issue] Segfault on s390x in Effect test #383

jmid opened this issue Aug 17, 2023 · 2 comments
Labels
ocaml5-issue A potential issue in the OCaml5 compiler/runtime

Comments

@jmid
Copy link
Collaborator

jmid commented Aug 17, 2023

After merging #381 to main I spotted a multicoretests-ci failure on s390x for 5.2+trunk
https://ocaml-multicoretests.ci.dev:8100/job/2023-08-17/073031-ci-ocluster-build-e8d54d#L1589

random seed: 97230569
generated error  fail  pass / total     time test name

[ ]     0     0     0     0 / 20000     0.0s Lin DSL ref int test with Effect
[ ]     0     0     0     0 / 20000     0.0s Lin DSL ref int test with Effect (generating)
[✓] 20000     0     0 20000 / 20000     0.4s Lin DSL ref int test with Effect

[ ]     0     0     0     0 / 20000     0.0s Lin DSL ref int64 test with Effect
[✓] 20000     0     0 20000 / 20000     0.4s Lin DSL ref int64 test with Effect

[ ]     0     0     0     0 / 20000     0.0s Lin DSL CList int test with Effect
[✓] 20000     0     0 20000 / 20000     0.4s Lin DSL CList int test with Effect

[ ]     0     0     0     0 / 20000     0.0s Lin DSL CList int64 test with Effect
[✓] 20000     0     0 20000 / 20000     0.5s Lin DSL CList int64 test with Effect

[ ]     0     0     0     0 / 20000     0.0s negative Lin DSL ref int test with EffectFile "src/neg_tests/dune", line 92, characters 7-27:
92 |  (name lin_tests_dsl_effect)
            ^^^^^^^^^^^^^^^^^^^^
(cd _build/default/src/neg_tests && ./lin_tests_dsl_effect.exe --verbose)
Command got signal SEGV.

After focusing and cleaning up I now have a reproducer in the https://github.com/ocaml-multicore/multicoretests/commits/s390x-crash-repro branch that consistently fails in the CI on both 5.1+trunk and 5.2+trunk.

I will open an OCaml issue for it shortly.

@jmid jmid added the ocaml5-issue A potential issue in the OCaml5 compiler/runtime label Aug 17, 2023
@jmid
Copy link
Collaborator Author

jmid commented Aug 18, 2023

Reported upstream in ocaml/ocaml#12486

@jmid
Copy link
Collaborator Author

jmid commented Sep 11, 2023

Closing as this was fixed and cherry-picked to 5.1.0~rc3 in ocaml/ocaml#12530

@jmid jmid closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ocaml5-issue A potential issue in the OCaml5 compiler/runtime
Projects
None yet
Development

No branches or pull requests

1 participant