Skip to content

Commit abdb794

Browse files
authored
Merge pull request #396 from ocaml-multicore/lin-renaming
Chore: renaming Lin Internal tests
2 parents 9d65779 + c332d03 commit abdb794

21 files changed

+71
-71
lines changed

src/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ Tests utilizing the parallel STM.ml capability:
4444

4545
Tests utilizing the linearization tests of Lin.ml:
4646

47-
- [array/lin_tests.ml](array/lin_tests.ml) and [array/lin_tests_dsl.ml](array/lin_tests_dsl.ml)
47+
- [array/lin_internal_tests.ml](array/lin_internal_tests.ml) and [array/lin_tests_dsl.ml](array/lin_tests_dsl.ml)
4848
contain experimental `Lin.Internal` and `Lin`-tests of `Array`
4949

50-
- [atomic/lin_tests.ml](atomic/lin_tests.ml) and [atomic/lin_tests_dsl.ml](atomic/lin_tests_dsl.ml)
50+
- [atomic/lin_internal_tests.ml](atomic/lin_internal_tests.ml) and [atomic/lin_tests_dsl.ml](atomic/lin_tests_dsl.ml)
5151
contain experimental `Lin.Internal` and `Lin`-tests of `Atomic`
5252

5353
- [bigarray/lin_tests_dsl.ml](bigarray/lin_tests_dsl.ml) contains experimental `Lin`-tests of `Bigarray`
@@ -58,16 +58,16 @@ Tests utilizing the linearization tests of Lin.ml:
5858

5959
- [floatarray/lin_tests_dsl.ml](floatarray/lin_tests_dsl.ml) contains experimental `Lin`-tests of `Float.Array`
6060

61-
- [hashtbl/lin_tests.ml](hashtbl/lin_tests.ml) and [hashtbl/lin_tests_dsl.ml](hashtbl/lin_tests_dsl.ml)
61+
- [hashtbl/lin_internal_tests.ml](hashtbl/lin_internal_tests.ml) and [hashtbl/lin_tests_dsl.ml](hashtbl/lin_tests_dsl.ml)
6262
contain experimental `Lin.Internal` and `Lin`-tests of `Hashtbl`
6363

64-
- [lazy/lin_tests.ml](lazy/lin_tests.ml) and [lazy/lin_tests_dsl.ml](lazy/lin_tests_dsl.ml)
64+
- [lazy/lin_internal_tests.ml](lazy/lin_internal_tests.ml) and [lazy/lin_tests_dsl.ml](lazy/lin_tests_dsl.ml)
6565
contain experimental `Lin.Internal` and `Lin`-tests of `Lazy`
6666

67-
- [queue/lin_tests.ml](queue/lin_tests.ml) and [queue/lin_tests_dsl.ml](queue/lin_tests_dsl.ml)
67+
- [queue/lin_internal_tests.ml](queue/lin_internal_tests.ml) and [queue/lin_tests_dsl.ml](queue/lin_tests_dsl.ml)
6868
contain experimental `Lin.Internal` and `Lin`-tests of `Queue`
6969

70-
- [stack/lin_tests.ml](stack/lin_tests.ml) and [stack/lin_tests_dsl.ml](stack/lin_tests_dsl.ml)
70+
- [stack/lin_internal_tests.ml](stack/lin_internal_tests.ml) and [stack/lin_tests_dsl.ml](stack/lin_tests_dsl.ml)
7171
contain experimental `Lin.Internal` and `Lin`-tests of `Stack`
7272

7373

@@ -96,7 +96,7 @@ that concurrency issues are indeed found as expected (aka. sanity
9696
check).
9797

9898
For `Lin.Internal` and `Lin`
99-
- [neg_tests/lin_tests_common.ml](neg_tests/lin_tests_common.ml) and
99+
- [neg_tests/lin_internal_tests_common.ml](neg_tests/lin_internal_tests_common.ml) and
100100
- [neg_tests/lin_tests_dsl_common.ml](neg_tests/lin_tests_dsl_common.ml)
101101

102102
contain "sanity check tests" for an unprotected global `ref` and a

src/array/dune

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
)
1010

1111
(test
12-
(name lin_tests)
13-
(modules lin_tests)
12+
(name lin_internal_tests)
13+
(modules lin_internal_tests)
1414
(package multicoretests)
1515
(flags (:standard -w -27))
1616
(libraries qcheck-lin.domain)

src/array/lin_tests.ml renamed to src/array/lin_internal_tests.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,5 +118,5 @@ end
118118
module AT_domain = Lin_domain.Make_internal(AConf) [@alert "-internal"]
119119
;;
120120
QCheck_base_runner.run_tests_main [
121-
AT_domain.neg_lin_test ~count:1000 ~name:"Lin Array test with Domain";
121+
AT_domain.neg_lin_test ~count:1000 ~name:"Lin.Internal Array test with Domain";
122122
]

src/atomic/dune

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
;; Linearization tests of Atomic, utilizing ppx_deriving_qcheck
1414

1515
(test
16-
(name lin_tests)
17-
(modules lin_tests)
16+
(name lin_internal_tests)
17+
(modules lin_internal_tests)
1818
(package multicoretests)
1919
(flags (:standard -w -27))
2020
(libraries qcheck-lin.domain)

src/atomic/lin_tests.ml renamed to src/atomic/lin_internal_tests.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,6 @@ end
190190
module A3T_domain = Lin_domain.Make_internal(A3Conf) [@alert "-internal"]
191191
;;
192192
QCheck_base_runner.run_tests_main [
193-
AT_domain.lin_test ~count:1000 ~name:"Lin Atomic test with Domain";
194-
A3T_domain.lin_test ~count:1000 ~name:"Lin Atomic3 test with Domain";
193+
AT_domain.lin_test ~count:1000 ~name:"Lin.Internal Atomic test with Domain";
194+
A3T_domain.lin_test ~count:1000 ~name:"Lin.Internal Atomic3 test with Domain";
195195
]

src/hashtbl/dune

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
)
1010

1111
(test
12-
(name lin_tests)
13-
(modules lin_tests)
12+
(name lin_internal_tests)
13+
(modules lin_internal_tests)
1414
(package multicoretests)
1515
(flags (:standard -w -27))
1616
(libraries qcheck-lin.domain)

src/hashtbl/lin_tests.ml renamed to src/hashtbl/lin_internal_tests.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,5 +125,5 @@ end
125125
module HT_domain = Lin_domain.Make_internal(HConf) [@alert "-internal"]
126126
;;
127127
QCheck_base_runner.run_tests_main [
128-
HT_domain.neg_lin_test ~count:1000 ~name:"Lin Hashtbl test with Domain";
128+
HT_domain.neg_lin_test ~count:1000 ~name:"Lin.Internal Hashtbl test with Domain";
129129
]

src/io/dune

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
;; Linearizability tests of the I/O operations
22

33
(test
4-
(name lin_tests)
5-
(modules lin_tests)
4+
(name lin_internal_tests)
5+
(modules lin_internal_tests)
66
(package multicoretests)
77
;(flags (:standard -w -27))
88
(libraries qcheck-lin.domain)

src/io/lin_tests.ml renamed to src/io/lin_internal_tests.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ module Out_channel_lin = Lin_domain.Make_internal (Out_channel_ops) [@@alert "-i
153153

154154
let () =
155155
QCheck_base_runner.run_tests_main
156-
[ In_channel_lin.lin_test ~count:1000 ~name:"Lin In_channel test with domains";
157-
Out_channel_lin.lin_test ~count:1000 ~name:"Lin Out_channel test with domains";
156+
[ In_channel_lin.lin_test ~count:1000 ~name:"Lin.Internal In_channel test with domains";
157+
Out_channel_lin.lin_test ~count:1000 ~name:"Lin.Internal Out_channel test with domains";
158158
]
159159

160160
let () =

src/lazy/dune

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
)
1010

1111
(test
12-
(name lin_tests)
13-
(modules lin_tests)
12+
(name lin_internal_tests)
13+
(modules lin_internal_tests)
1414
(package multicoretests)
1515
(libraries qcheck-lin.domain)
1616
; (action (run %{test} --verbose))

src/lazy/lin_tests.ml renamed to src/lazy/lin_internal_tests.ml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ module LTfromfun = Lin_domain.Make_internal(struct
133133
;;
134134
QCheck_base_runner.run_tests_main
135135
(let count = 100 in
136-
[LTlazy.neg_lin_test ~count ~name:"Lin Lazy test with Domain";
137-
LTfromval.lin_test ~count ~name:"Lin Lazy test with Domain from_val";
138-
LTfromfun.neg_lin_test ~count ~name:"Lin Lazy test with Domain from_fun";
136+
[LTlazy.neg_lin_test ~count ~name:"Lin.Internal Lazy test with Domain";
137+
LTfromval.lin_test ~count ~name:"Lin.Internal Lazy test with Domain from_val";
138+
LTfromfun.neg_lin_test ~count ~name:"Lin.Internal Lazy test with Domain from_fun";
139139
])

src/neg_tests/dune

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@
6363
)
6464

6565
(library
66-
(name lin_tests_common)
67-
(modules lin_tests_common)
66+
(name lin_internal_tests_common)
67+
(modules lin_internal_tests_common)
6868
(package multicoretests)
6969
(libraries CList qcheck-lin.lin)
7070
)
@@ -100,30 +100,30 @@
100100
;; Linearization tests of ref and Clist with Lin.Internal
101101

102102
(test
103-
(name lin_tests_domain)
104-
(modules lin_tests_domain)
103+
(name lin_internal_tests_domain)
104+
(modules lin_internal_tests_domain)
105105
(package multicoretests)
106106
(flags (:standard -w -27))
107-
(libraries lin_tests_common qcheck-lin.domain)
107+
(libraries lin_internal_tests_common qcheck-lin.domain)
108108
; (action (run %{test} --verbose))
109109
(action (echo "Skipping src/neg_tests/%{test} from the test suite\n\n"))
110110
)
111111

112112
(tests
113-
(names lin_tests_thread_ref lin_tests_thread_conclist)
114-
(modules lin_tests_thread_ref lin_tests_thread_conclist)
113+
(names lin_internal_tests_thread_ref lin_internal_tests_thread_conclist)
114+
(modules lin_internal_tests_thread_ref lin_internal_tests_thread_conclist)
115115
(package multicoretests)
116116
(flags (:standard -w -27))
117-
(libraries lin_tests_common qcheck-lin.thread)
117+
(libraries lin_internal_tests_common qcheck-lin.thread)
118118
(action (run %{test} --verbose))
119119
)
120120

121121
(test
122-
(name lin_tests_effect)
123-
(modules lin_tests_effect)
122+
(name lin_internal_tests_effect)
123+
(modules lin_internal_tests_effect)
124124
(package multicoretests)
125125
(flags (:standard -w -27))
126-
(libraries lin_tests_common qcheck-lin.effect)
126+
(libraries lin_internal_tests_common qcheck-lin.effect)
127127
; (action (run ./%{deps} --verbose))
128128
(action (echo "Skipping src/neg_tests/%{test} from the test suite\n\n"))
129129
)
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
open Lin_tests_common
1+
open Lin_internal_tests_common
22

33
module RT_int_domain = Lin_domain.Make_internal(RConf_int) [@alert "-internal"]
44
module RT_int64_domain = Lin_domain.Make_internal(RConf_int64) [@alert "-internal"]
@@ -10,7 +10,7 @@ module CLT_int64_domain = Lin_domain.Make_internal(CLConf (Int64)) [@alert "-int
1010
;;
1111
QCheck_base_runner.run_tests_main
1212
(let count = 15000 in
13-
[RT_int_domain.neg_lin_test ~count ~name:"Lin ref int test with Domain";
14-
RT_int64_domain.neg_lin_test ~count ~name:"Lin ref int64 test with Domain";
15-
CLT_int_domain.neg_lin_test ~count ~name:"Lin CList int test with Domain";
16-
CLT_int64_domain.neg_lin_test ~count ~name:"Lin CList int64 test with Domain"])
13+
[RT_int_domain.neg_lin_test ~count ~name:"Lin.Internal ref int test with Domain";
14+
RT_int64_domain.neg_lin_test ~count ~name:"Lin.Internal ref int64 test with Domain";
15+
CLT_int_domain.neg_lin_test ~count ~name:"Lin.Internal CList int test with Domain";
16+
CLT_int64_domain.neg_lin_test ~count ~name:"Lin.Internal CList int64 test with Domain"])

src/neg_tests/lin_tests_effect.ml renamed to src/neg_tests/lin_internal_tests_effect.ml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
open Lin_tests_common
1+
open Lin_internal_tests_common
22

33
(** This is a driver of the negative tests over the Effect module *)
44

@@ -151,13 +151,13 @@ module CLT_int64'_effect = Lin_effect.Make_internal(CLConf_int64') [@alert "-int
151151
QCheck_base_runner.run_tests_main
152152
(let count = 20_000 in [
153153
(* We don't expect the first four tests to fail as each `cmd` is completed before a `Yield` *)
154-
RT_int_effect.lin_test ~count ~name:"Lin ref int test with Effect";
155-
RT_int64_effect.lin_test ~count ~name:"Lin ref int64 test with Effect";
156-
CLT_int_effect.lin_test ~count ~name:"Lin CList int test with Effect";
157-
CLT_int64_effect.lin_test ~count ~name:"Lin CList int64 test with Effect";
154+
RT_int_effect.lin_test ~count ~name:"Lin.Internal ref int test with Effect";
155+
RT_int64_effect.lin_test ~count ~name:"Lin.Internal ref int64 test with Effect";
156+
CLT_int_effect.lin_test ~count ~name:"Lin.Internal CList int test with Effect";
157+
CLT_int64_effect.lin_test ~count ~name:"Lin.Internal CList int64 test with Effect";
158158
(* These next four tests are negative - and are expected to fail with exception `Unhandled` *)
159-
RT_int'_effect.neg_lin_test ~count ~name:"negative Lin ref int test with Effect";
160-
RT_int64'_effect.neg_lin_test ~count ~name:"negative Lin ref int64 test with Effect";
161-
CLT_int'_effect.neg_lin_test ~count ~name:"negative Lin CList int test with Effect";
162-
CLT_int64'_effect.neg_lin_test ~count ~name:"negative Lin CList int64 test with Effect"
159+
RT_int'_effect.neg_lin_test ~count ~name:"negative Lin.Internal ref int test with Effect";
160+
RT_int64'_effect.neg_lin_test ~count ~name:"negative Lin.Internal ref int64 test with Effect";
161+
CLT_int'_effect.neg_lin_test ~count ~name:"negative Lin.Internal CList int test with Effect";
162+
CLT_int64'_effect.neg_lin_test ~count ~name:"negative Lin.Internal CList int64 test with Effect"
163163
])

src/neg_tests/lin_tests_thread_conclist.ml renamed to src/neg_tests/lin_internal_tests_thread_conclist.ml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
open Lin_tests_common
1+
open Lin_internal_tests_common
22

33
(** This is a driver of the negative CList tests over the Thread module *)
44

@@ -8,12 +8,12 @@ module CLT_int64_thread = Lin_thread.Make_internal(CLConf (Int64)) [@alert "-int
88
let _ =
99
let count = 1000 in
1010
let tests = [
11-
CLT_int_thread.lin_test ~count ~name:"Lin CList int test with Thread"; (* unboxed, hence no allocations to trigger context switch *)
12-
CLT_int64_thread.lin_test ~count ~name:"Lin CList int64 test with Thread" (* not triggering context switch, unfortunately *)
11+
CLT_int_thread.lin_test ~count ~name:"Lin.Internal CList int test with Thread"; (* unboxed, hence no allocations to trigger context switch *)
12+
CLT_int64_thread.lin_test ~count ~name:"Lin.Internal CList int64 test with Thread" (* not triggering context switch, unfortunately *)
1313
] in
1414
let tests =
1515
if Sys.backend_type = Sys.Bytecode then (
16-
Printf.printf "Lin CList int64 test with Thread disabled under bytecode\n\n%!";
16+
Printf.printf "Lin.Internal CList int64 test with Thread disabled under bytecode\n\n%!";
1717
[ List.hd tests ])
1818
else tests
1919
in

src/neg_tests/lin_tests_thread_ref.ml renamed to src/neg_tests/lin_internal_tests_thread_ref.ml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
open Lin_tests_common
1+
open Lin_internal_tests_common
22

33
(** This is a driver of the negative ref tests over the Thread module *)
44

@@ -11,9 +11,9 @@ module RT_int64_thread = Lin_thread.Make_internal(struct
1111
;;
1212
if Sys.backend_type = Sys.Bytecode
1313
then
14-
Printf.printf "Lin ref tests with Thread disabled under bytecode\n\n%!"
14+
Printf.printf "Lin.Internal ref tests with Thread disabled under bytecode\n\n%!"
1515
else
1616
QCheck_base_runner.run_tests_main
1717
(let count = 1000 in
18-
[RT_int_thread.lin_test ~count ~name:"Lin ref int test with Thread"; (* unboxed, hence no allocations to trigger context switch *)
19-
RT_int64_thread.neg_lin_test ~count:15000 ~name:"Lin ref int64 test with Thread"])
18+
[RT_int_thread.lin_test ~count ~name:"Lin.Internal ref int test with Thread"; (* unboxed, hence no allocations to trigger context switch *)
19+
RT_int64_thread.neg_lin_test ~count:15000 ~name:"Lin.Internal ref int64 test with Thread"])

src/queue/dune

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
)
1111

1212
(test
13-
(name lin_tests)
14-
(modules lin_tests)
13+
(name lin_internal_tests)
14+
(modules lin_internal_tests)
1515
(package multicoretests)
1616
(flags (:standard -w -27))
1717
(libraries qcheck-lin.domain qcheck-lin.thread)

src/queue/lin_tests.ml renamed to src/queue/lin_internal_tests.ml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,8 @@ module QT_domain = Lin_domain.Make_internal(QConf) [@alert "-internal"]
171171
module QT_thread = Lin_thread.Make_internal(QConf) [@alert "-internal"]
172172
;;
173173
QCheck_base_runner.run_tests_main [
174-
QMT_domain.lin_test ~count:1000 ~name:"Lin Queue test with Domain and mutex";
175-
QMT_thread.lin_test ~count:1000 ~name:"Lin Queue test with Thread and mutex";
176-
QT_domain.neg_lin_test ~count:1000 ~name:"Lin Queue test with Domain without mutex";
177-
QT_thread.lin_test ~count:1000 ~name:"Lin Queue test with Thread without mutex";
174+
QMT_domain.lin_test ~count:1000 ~name:"Lin.Internal Queue test with Domain and mutex";
175+
QMT_thread.lin_test ~count:1000 ~name:"Lin.Internal Queue test with Thread and mutex";
176+
QT_domain.neg_lin_test ~count:1000 ~name:"Lin.Internal Queue test with Domain without mutex";
177+
QT_thread.lin_test ~count:1000 ~name:"Lin.Internal Queue test with Thread without mutex";
178178
]

src/stack/dune

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
)
1111

1212
(test
13-
(name lin_tests)
14-
(modules lin_tests)
13+
(name lin_internal_tests)
14+
(modules lin_internal_tests)
1515
(package multicoretests)
1616
(flags (:standard -w -27))
1717
(libraries qcheck-lin.domain qcheck-lin.thread)

src/stack/lin_tests.ml renamed to src/stack/lin_internal_tests.ml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,8 @@ module SMT_domain = Lin_domain.Make_internal(SMutexConf) [@alert "-internal"]
171171
module SMT_thread = Lin_thread.Make_internal(SMutexConf) [@alert "-internal"]
172172
;;
173173
QCheck_base_runner.run_tests_main [
174-
SMT_domain.lin_test ~count:1000 ~name:"Lin Stack test with Domain and mutex";
175-
SMT_thread.lin_test ~count:1000 ~name:"Lin Stack test with Thread and mutex";
176-
ST_domain.neg_lin_test ~count:1000 ~name:"Lin Stack test with Domain without mutex";
177-
ST_thread.lin_test ~count:1000 ~name:"Lin Stack test with Thread without mutex";
174+
SMT_domain.lin_test ~count:1000 ~name:"Lin.Internal Stack test with Domain and mutex";
175+
SMT_thread.lin_test ~count:1000 ~name:"Lin.Internal Stack test with Thread and mutex";
176+
ST_domain.neg_lin_test ~count:1000 ~name:"Lin.Internal Stack test with Domain without mutex";
177+
ST_thread.lin_test ~count:1000 ~name:"Lin.Internal Stack test with Thread without mutex";
178178
]

0 commit comments

Comments
 (0)