From bf7200e1a0e1ac743d63ec2ad8fa75f65b2342af Mon Sep 17 00:00:00 2001 From: David Sancho Moreno Date: Thu, 8 May 2025 10:54:30 +0200 Subject: [PATCH 1/4] Add macos-latest and windows-latest (windows is expected to crash) --- .github/workflows/main.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a8d4a49..baffb0b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -15,6 +15,9 @@ jobs: matrix: os: - ubuntu-latest + - macos-latest + - windows-latest + ocaml-compiler: - "4.14" - "5.1" From 3a21a4e38a67c6fccac83fd7dd87010abd6cdc55 Mon Sep 17 00:00:00 2001 From: David Sancho Moreno Date: Thu, 8 May 2025 13:06:18 +0200 Subject: [PATCH 2/4] set_binary_mode in stdout --- mlx/pp.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/mlx/pp.ml b/mlx/pp.ml index 81fc498..5573e5c 100644 --- a/mlx/pp.ml +++ b/mlx/pp.ml @@ -32,6 +32,7 @@ let () = if !print_ml then Format.printf "%a@." Pprintast.structure str else let oc = stdout in + Out_channel.set_binary_mode oc true; output_string oc Ppxlib_ast.Compiler_version.Ast.Config.ast_impl_magic_number; output_value oc fname; From aa522181d9129f2d28c6257caeb0e88e5fe767e6 Mon Sep 17 00:00:00 2001 From: David Sancho Moreno Date: Thu, 8 May 2025 13:14:25 +0200 Subject: [PATCH 3/4] split dune builds to test windows --- .github/workflows/main.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index baffb0b..baaf7cb 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -41,7 +41,9 @@ jobs: - run: opam install . --deps-only --with-test - - run: opam exec -- dune build -p mlx,ocamlmerlin-mlx + - run: opam exec -- dune build -p mlx + + - run: opam exec -- dune build -p ocamlmerlin-mlx # TODO: pass --with-dev-setup to opam instead? (requires opam 2.2, I think) - run: opam install menhir.20201216 menhirLib.20201216 menhirSdk.20201216 ocamlformat From 0558068544cbb78c499b70f2ba326d6a36b3203b Mon Sep 17 00:00:00 2001 From: David Sancho Moreno Date: Thu, 8 May 2025 13:30:40 +0200 Subject: [PATCH 4/4] Remove merlin to test mlx? --- .github/workflows/main.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index baaf7cb..6cda41d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -43,8 +43,6 @@ jobs: - run: opam exec -- dune build -p mlx - - run: opam exec -- dune build -p ocamlmerlin-mlx - # TODO: pass --with-dev-setup to opam instead? (requires opam 2.2, I think) - run: opam install menhir.20201216 menhirLib.20201216 menhirSdk.20201216 ocamlformat