Skip to content

Update: Add a Kdtree collection type, collect from Kdtree at a box #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2025
Merged

Update: Add a Kdtree collection type, collect from Kdtree at a box #9

merged 4 commits into from
May 24, 2025

Conversation

902D9
Copy link
Contributor

@902D9 902D9 commented Apr 29, 2025 •
edited
Loading

The circle may cause the points at the boundary to not be collected, so a method to collect the points inside the box is added.

image
image
image

image

@nutti nutti added the enhancement New feature or request label May 1, 2025
nutti
nutti reviewed May 1, 2025
View reviewed changes
Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @902D9 for the contribution!
This seems a great addition to this plugin.

"Box" collection method itself is good to me.
But the user interface needs to be improved.
I think using the radius parameter for the box method is not intuitive.
Instead, adding a new Blueprint function Collect From Kdtree (Cube) and changing the existing Blueprint function name to Collect From Kdtree (Sphere) would be better.
Also, Collect From Kdtree (Cube) should accept a edge length instead of radius.

@902D9
Copy link
Contributor Author

902D9 commented May 6, 2025

Added a new function called Collect From Kdtree (Box) and changed the display name of the original function to Collect From Kdtree (Sphere)
image
image

nutti
nutti requested changes May 11, 2025
View reviewed changes
Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@902D9
Thank you for creating a separated function.
Please improve the code structure based on my suggestion.

@902D9
Copy link
Contributor Author

902D9 commented May 19, 2025

Thank you for creating a separated function.
Please improve the code structure based on my suggestion.

I have improved the code as you suggested.

nutti
nutti requested changes May 24, 2025
View reviewed changes
Copy link
Owner

@nutti nutti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@902D9
Thank you. All code looks good to me.
Please delete Kdtree/Config/DefaultKdtree.ini. I think this file is unintentionally included.

@902D9
Copy link
Contributor Author

902D9 commented May 24, 2025

@902D9 Thank you. All code looks good to me. Please delete Kdtree/Config/DefaultKdtree.ini. I think this file is unintentionally included.

This file contains the redirection information for the above function renames. If the blueprint in the project uses the old named function, it can help it identify the renamed C++ function.
If you don't want the plugin to include these redirect information, I can delete it.

@nutti
Copy link
Owner

nutti commented May 24, 2025

@902D9

This PR is not released yet.
So, we can delete this file safely.

@902D9
Copy link
Contributor Author

902D9 commented May 24, 2025

Deleted

@nutti nutti merged commit 7bac928 into nutti:master May 24, 2025
5 of 23 checks passed
@nutti
Copy link
Owner

nutti commented May 24, 2025

@902D9

Merged.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutti nutti nutti approved these changes

Assignees

@902D9 902D9

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@902D9 @nutti