Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist of format #13

Open
1 of 2 tasks
AucaCoyan opened this issue Jun 2, 2023 · 0 comments
Open
1 of 2 tasks

Checklist of format #13

AucaCoyan opened this issue Jun 2, 2023 · 0 comments
Labels
enhancement New feature or request meta-issue

Comments

@AucaCoyan
Copy link
Contributor

AucaCoyan commented Jun 2, 2023

Status of formatting Shapes in nufmt

FlatShape is a struct that gives me the type of contents to format. Based in this struct, the code decides how to output.
The following checklist runs down on the state of every enum case, separated in groups:

solved, no problem raised:

  • String
  • Int
  • Nothing
  • List
  • Record
  • Pipe
  • External

(partially) handled, but some problems occured:

  • ExternalArg: This FlatShape is the argument of the Extenal enum. Most of the time is a long pipeline. I didn't handle the arguments recurively yet. I don't like recursion.
  • Garbage: I don't know why this is called garbage. Usually starts with a let statement, or sometimes with a comment. Normally it grabs the first line after a comment.

remaining to handle:

This enums I haven't found them yet, or didn't tried. With further tests we'll check it.

  • And:
  • Binary:
  • Block:
  • Bool:
  • Closure:
  • Custom(DeclId):
  • DateTime:
  • Directory:
  • Filepath:
  • Flag:
  • Float:
  • GlobPattern:
  • InternalCall(DeclId) :
  • Keyword:
  • Literal:
  • MatchPattern:
  • Operator:
  • Or:
  • Range:
  • Redirection:
  • Signature:
  • StringInterpolation:
  • Table:
  • Variable(VarId):

Tasks left to do:

  • test every case at least once.
  • add automatic testing.
@AucaCoyan AucaCoyan mentioned this issue Jun 2, 2023
22 tasks
@amtoine amtoine added enhancement New feature or request meta-issue labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request meta-issue
Projects
None yet
Development

No branches or pull requests

2 participants