Test cases with ArgDisplayNames containing closing braces ) are recognized as a different test and names are truncated after first closing brace

[MineCake147E]

Description

When discovering the test cases with non-string arguments that have argument display names containing closing braces() (U+0029 RIGHT PARENTHESIS)), NUnit3TestAdapter (if not VS2026) treats them as if it were the end of the argument list, and truncates the test display name after that.
On the other hand, it can handle the string arguments with ) fine, unless the next character is . (U+002E FULL STOP).

namespace VSTestAdapterArgNameCloseBraceBugRepro
{
    public class Tests
    {
        private static IEnumerable<TestCaseData> ArgDisplayNamesTestCaseSource()
        {
            yield return new TestCaseData(0).SetArgDisplayNames("AAAA");
            yield return new TestCaseData(1).SetArgDisplayNames("AAAA(AAAA");
            yield return new TestCaseData(2).SetArgDisplayNames("AAAA)AAAA");
            yield return new TestCaseData(3).SetArgDisplayNames("AAAA(AAAA)AAAA");
        }
        private static IEnumerable<TestCaseData> TestCaseDataToStringTestCaseSource()
        {
            yield return new TestCaseData(new FileInfo("AAAA"));
            yield return new TestCaseData(new FileInfo("AAAA(AAAA"));
            yield return new TestCaseData(new FileInfo("AAAA)AAAA"));
            yield return new TestCaseData(new FileInfo("AAAA(AAAA)AAAA"));
        }
        private static IEnumerable<FileInfo> FileInfoToStringTestCaseSource()
        {
            yield return new FileInfo("AAAA");
            yield return new FileInfo("AAAA(AAAA");
            yield return new FileInfo("AAAA)AAAA");
            yield return new FileInfo("AAAA(AAAA)AAAA");
        }
        private static IEnumerable<TestCaseData> QuotedArgDisplayNamesTestCaseSource()
        {
            yield return new TestCaseData(0).SetArgDisplayNames("\"AAAA\"");
            yield return new TestCaseData(1).SetArgDisplayNames("\"AAAA(AAAA\"");
            yield return new TestCaseData(2).SetArgDisplayNames("\"AAAA)AAAA\"");
            yield return new TestCaseData(3).SetArgDisplayNames("\"AAAA(AAAA)AAAA\"");
            yield return new TestCaseData(4).SetArgDisplayNames("\"Files\\A.zip\"");
            yield return new TestCaseData(5).SetArgDisplayNames("\"Files\\AAAA(AAAA.zip\"");
            yield return new TestCaseData(6).SetArgDisplayNames("\"Files\\AAAA)AAAA.zip\"");
            yield return new TestCaseData(7).SetArgDisplayNames("\"Files\\AAAA(AAAA)AAAA.zip\"");
            yield return new TestCaseData(9).SetArgDisplayNames("\"Files\\A(2.3).zip\"");
            yield return new TestCaseData(10).SetArgDisplayNames("\"Files\\AAAA(AAAA).zip\"");
            yield return new TestCaseData(11).SetArgDisplayNames("\"Files\\AAAA)AAAA).zip\"");
            yield return new TestCaseData(12).SetArgDisplayNames("\"Files\\AAAA(AA.AA)AAAA.zip\"");
        }

        [TestCase("AAAA")]
        [TestCase("AAAA(AAAA")]
        [TestCase("AAAA)AAAA")]
        [TestCase("AAAA(AAAA)AAAA")]
        [TestCase("Files\\A(2.3).zip")]
        [TestCase("Files\\AAAA(AAAA).zip")]
        [TestCase("Files\\AAAA)AAAA).zip")]
        [TestCase("Files\\AAAA(AA.AA)AAAA.zip")]
        public void Test1(string name) => Assert.Pass();

        [TestCaseSource(nameof(ArgDisplayNamesTestCaseSource))]
        public void Test2(int value) => Assert.Pass();

        [TestCaseSource(nameof(TestCaseDataToStringTestCaseSource))]
        public void Test3(FileInfo value) => Assert.Pass();

        [TestCaseSource(nameof(FileInfoToStringTestCaseSource))]
        public void Test4(FileInfo value) => Assert.Pass();

        [TestCaseSource(nameof(QuotedArgDisplayNamesTestCaseSource))]
        public void Test5(int value) => Assert.Pass();
    }
}

Expected Behaviour

All tests for the same method show up in a single group.

Actual Behaviour

Other Information

VSTestAdapterArgNameCloseBraceBugRepro.csproj

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net10.0</TargetFramework>
    <LangVersion>latest</LangVersion>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <IsPackable>false</IsPackable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="coverlet.collector" Version="6.0.4" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
    <PackageReference Include="NUnit" Version="4.4.0" />
    <PackageReference Include="NUnit.Analyzers" Version="4.11.2">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
    <PackageReference Include="NUnit3TestAdapter" Version="5.2.0" />
  </ItemGroup>

  <ItemGroup>
    <Using Include="NUnit.Framework" />
  </ItemGroup>

</Project>

[OsirisTerje]

@MineCake147E Thanks for a good repro!

I have added your code as a repro here: https://github.com/nunit/nunit3-vs-adapter.issues/tree/master/Issue1357

In this repro I have added dump'ing using the .runsettings file. If you look at the execution dump, you will see exactly what the adapter sends out. And, that is the full named line, as in your testcases. (I have enclosed the dump file zip'ed).

E_Issue1357.dll.zip

Also, if you check the output from dotnet test --logger "console;verbosity=normal" you will see all tests correctly named.

So the problem is in the Test Explorer.

And, it the way the Test Explorer groups the tests. The default is Project/NameSpace/Class, and that will then look like this, matching what you have observed.

If you change the grouping to only use Project (which is actually no grouping at all), it all looks fine:

So, the test explorer doesn't understand these "complex" names, and use the ) and . as a sign of going one level down. It follows sort of the C# FQN.

The reason for the two top nodes are a bit weird, but it is also the Test Explorer being confused by this.

Just for "fun": Visual Studio Code with the Test Explorer extension from Jun Han behaves the exact same way.

Now, if we look at the events from the dump file you will see that NUnit give you a complete tree based on the real structure of the tests, note Assembly on top, then every level down to a class is a TestSuite, the class is a TestFixture, the test method is next level, and in the end you have the test itself. This structure is test based.

Unfortunately, Test Explorer don't want to display things this way. However, if you use [TestCentric[(https://test-centric.org/) (from @CharliePoole ) you can see that real structure.

PS: If you try this, note that it is bundled with max Net 6.0 agent, and I couldn't make the net 10 work there, but Charlie will fix this soon.