-
Notifications
You must be signed in to change notification settings - Fork 71
Dual-Axis support? What about fsync mode context? #1
Copy link
Copy link
Open
Description
Hey @nubskr,
I was thinking it'd be great to have Dual-Axis support for Walrus. For example maybe putting something under
walrus/scripts/visualize_throughput.py
Line 41 in 77c9fbb
| # Set up better Y-axis formatting |
That looks something similar to this:
def create_dual_axis_plot(self):
self.fig, self.ax1 = plt.subplots(1, 1, figsize=(12, 6))
self.ax2 = self.ax1.twinx()
self.ax1.set_ylabel('Writes/sec', color='b')
self.ax1.tick_params(axis='y', labelcolor='b')
self.ax2.set_ylabel('MB/sec', color='r')
self.ax2.tick_params(axis='y', labelcolor='r')I also realized whilst using Walrus, I didn't see any fsync mode context. So essentially the benchmarks can run with different fsync settings, but the visualization doesn't show which mode was used, any plan when updates/versions are pushed out this may be a feature?
Thanks for Walrus @nubskr, been super helpful to me for this project I'm working on.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels