Fix RuboCop offenses

- Remove redundant begin blocks in upload loops
- Disable Metrics/ClassLength for extended classes

Author: ntsk

lib/fastlane/plugin/amazon_appstore/actions/upload_to_amazon_appstore_action.rb

@@ -3,7 +3,7 @@
 
 module Fastlane
   module Actions
-    class UploadToAmazonAppstoreAction < Action
+    class UploadToAmazonAppstoreAction < Action # rubocop:disable Metrics/ClassLength
       def self.run(params) # rubocop:disable Metrics/PerceivedComplexity
         Helper::AmazonAppstoreHelper.setup(
           timeout: params[:timeout]
@@ -182,19 +182,17 @@ def self.upload_images(params, edit_id, token)
             end
 
             images.each do |image_path|
-              begin
-                Helper::AmazonAppstoreHelper.upload_image(
-                  app_id: params[:package_name],
-                  edit_id: edit_id,
-                  language: language,
-                  image_type: image_type,
-                  image_path: image_path,
-                  token: token
-                )
-                UI.message("Uploaded #{image_type} for #{language}: #{File.basename(image_path)}")
-              rescue StandardError => e
-                UI.error("Failed to upload #{image_type} for #{language}: #{e.message}")
-              end
+              Helper::AmazonAppstoreHelper.upload_image(
+                app_id: params[:package_name],
+                edit_id: edit_id,
+                language: language,
+                image_type: image_type,
+                image_path: image_path,
+                token: token
+              )
+              UI.message("Uploaded #{image_type} for #{language}: #{File.basename(image_path)}")
+            rescue StandardError => e
+              UI.error("Failed to upload #{image_type} for #{language}: #{e.message}")
             end
           end
         end
@@ -227,19 +225,17 @@ def self.upload_screenshots(params, edit_id, token)
             end
 
             screenshots.each do |screenshot_path|
-              begin
-                Helper::AmazonAppstoreHelper.upload_image(
-                  app_id: params[:package_name],
-                  edit_id: edit_id,
-                  language: language,
-                  image_type: image_type,
-                  image_path: screenshot_path,
-                  token: token
-                )
-                UI.message("Uploaded #{image_type} for #{language}: #{File.basename(screenshot_path)}")
-              rescue StandardError => e
-                UI.error("Failed to upload #{image_type} for #{language}: #{e.message}")
-              end
+              Helper::AmazonAppstoreHelper.upload_image(
+                app_id: params[:package_name],
+                edit_id: edit_id,
+                language: language,
+                image_type: image_type,
+                image_path: screenshot_path,
+                token: token
+              )
+              UI.message("Uploaded #{image_type} for #{language}: #{File.basename(screenshot_path)}")
+            rescue StandardError => e
+              UI.error("Failed to upload #{image_type} for #{language}: #{e.message}")
             end
           end
         end

lib/fastlane/plugin/amazon_appstore/helper/amazon_appstore_helper.rb

@@ -7,7 +7,7 @@ module Fastlane
   UI = FastlaneCore::UI unless Fastlane.const_defined?(:UI)
 
   module Helper
-    class AmazonAppstoreHelper
+    class AmazonAppstoreHelper # rubocop:disable Metrics/ClassLength
       BASE_URL = 'https://developer.amazon.com'
       AUTH_URL = 'https://api.amazon.com/auth/o2/token'