Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User configuration #180

Closed
jdfreder opened this issue Feb 22, 2016 · 5 comments
Closed

User configuration #180

jdfreder opened this issue Feb 22, 2016 · 5 comments
Assignees
Milestone

Comments

@jdfreder
Copy link
Contributor

For example, user keymap.json files.

@rgbkrk suggests an 'nteract' subfolder of the jupyter user config dirs.

@kenwheeler any opinions here? Jupyter kind of does it own thing regarding user config folder location. In the past this has lead to confusion across various operating systems. Maybe we should use a standard like xdg or something similar.

@rgbkrk
Copy link
Member

rgbkrk commented Feb 22, 2016

We do still need to implement the XDG specification in jupyter-paths as well: nteract/jupyter-paths#8, to, at the very least, find all the kernels available in Linux.

I lean towards the config folder of Jupyter (with our own namespace) just so we don't have to establish yet another standard. I do recognize that ~/.nteract is far more convenient in docs. At least in Atom, they make it discoverable within both the command palette and the top level Atom menu:

screenshot 2016-02-21 20 17 06

Once it's discoverable that way, it's less relevant where we store them. We can then rely on the Jupyter config directory.

@jdfreder
Copy link
Contributor Author

Yeah, I think you're right about adding a menu shortcut. That's a neat idea and really frees the user up from having to know the details.

@kenwheeler
Copy link
Contributor

In my latest PR, https://github.com/nteract/nteract/pull/306/files, I'm using electron-json-storage https://github.com/jviotti/electron-json-storage to write user prefs to app.getPath('userData).

Reasons for this:

  • The user data path varies by OS
  • localStorage isn't available in the main process

@rgbkrk rgbkrk added this to the Beta milestone Sep 21, 2016
@rgbkrk rgbkrk changed the title Where will user config will be stored??? User configuration Sep 26, 2016
@rgbkrk rgbkrk self-assigned this Sep 26, 2016
@captainsafia
Copy link
Member

This can be closed since it was implemented in #922.

@lock
Copy link

lock bot commented Apr 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants