Preserve governed effect metadata in bridge

Author: nshkrdotcom

bridges/mezzanine_bridge/lib/app_kit/bridges/mezzanine_bridge/effect_adapter.ex

@@ -100,11 +100,27 @@ defmodule AppKit.Bridges.MezzanineBridge.EffectAdapter do
       receipt_ref: run.effect.receipt_ref,
       dispatch_ref: run.effect.dispatch_ref,
       expected_version: run.effect.expected_version,
-      metadata: %{
-        "trace_summary_hash" => Map.get(projection, "trace_summary_hash")
-      }
+      metadata: metadata_from_run(run, projection)
     })
   end
 
   defp command_value(command, key), do: Map.get(command, key, Map.get(command, to_string(key)))
+
+  defp metadata_from_run(%Run{} = run, projection) do
+    run.command
+    |> command_value(:metadata)
+    |> normalize_metadata()
+    |> put_optional("trace_summary_hash", Map.get(projection, "trace_summary_hash"))
+    |> put_optional("evidence_refs", Map.get(projection, "evidence_refs"))
+  end
+
+  defp normalize_metadata(%{} = metadata) do
+    Map.new(metadata, fn {key, value} -> {to_string(key), value} end)
+  end
+
+  defp normalize_metadata(_metadata), do: %{}
+
+  defp put_optional(metadata, _key, nil), do: metadata
+  defp put_optional(metadata, _key, []), do: metadata
+  defp put_optional(metadata, key, value), do: Map.put(metadata, key, value)
 end

bridges/mezzanine_bridge/test/app_kit/bridges/mezzanine_bridge_governed_effect_integration_test.exs

@@ -29,6 +29,8 @@ defmodule AppKit.Bridges.MezzanineBridgeGovernedEffectIntegrationTest do
 
     assert proposed.effect_ref == attrs.effect_ref
     assert proposed.status == "proposed"
+    assert proposed.metadata["diagnostic_lane"] == "echo"
+    assert proposed.metadata["product_slug"] == "app-kit"
 
     assert {:ok, %Run{} = run} = Coordinator.propose(command_attrs(attrs))
 
@@ -40,6 +42,9 @@ defmodule AppKit.Bridges.MezzanineBridgeGovernedEffectIntegrationTest do
 
     assert readback.effect_ref == proposed.effect_ref
     assert readback.status == "proposed"
+    assert readback.metadata["diagnostic_lane"] == "echo"
+    assert readback.metadata["product_slug"] == "app-kit"
+    assert readback.metadata["trace_summary_hash"]
 
     assert {:ok, %EffectTimelineDTO{} = timeline} =
              EffectSurface.get_effect_timeline(context(), attrs.effect_ref,
@@ -227,7 +232,8 @@ defmodule AppKit.Bridges.MezzanineBridgeGovernedEffectIntegrationTest do
       trace_ref: Map.fetch!(attrs, :trace_ref),
       expected_version: Map.fetch!(attrs, :expected_version),
       operation: Map.fetch!(attrs, :effect_type),
-      payload: diagnostic_payload(attrs)
+      payload: diagnostic_payload(attrs),
+      metadata: diagnostic_metadata(attrs)
     }
   end
 
@@ -282,6 +288,14 @@ defmodule AppKit.Bridges.MezzanineBridgeGovernedEffectIntegrationTest do
 
   defp diagnostic_payload(attrs), do: %{"message" => "AppKit #{attrs.token} integration"}
 
+  defp diagnostic_metadata(attrs) do
+    %{
+      "diagnostic_lane" => "echo",
+      "product_slug" => "app-kit",
+      "run_ref" => "run://app-kit/integration/#{attrs.token}"
+    }
+  end
+
   defp effect_attrs(token, opts \\ []) do
     effect_type = Keyword.get(opts, :effect_type, "diagnostic.echo")
 
@@ -295,7 +309,8 @@ defmodule AppKit.Bridges.MezzanineBridgeGovernedEffectIntegrationTest do
       installation_ref: "installation://app-kit/default",
       status: "proposed",
       trace_ref: "trace:app-kit-integration-#{token}",
-      expected_version: 1
+      expected_version: 1,
+      metadata: diagnostic_metadata(%{token: token})
     }
   end