fix(rspack): expand serve-static target names for init generator #32587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=lint,test,build,e2e,e2e-c... |
✅ Succeeded | 27m 24s | View ↗ |
nx run-many -t check-imports check-commit check... |
✅ Succeeded | 1m 48s | View ↗ |
nx-cloud record -- nx-cloud conformance:check |
✅ Succeeded | 2s | View ↗ |
nx-cloud record -- nx format:check |
✅ Succeeded | 7s | View ↗ |
nx-cloud record -- nx sync:check |
✅ Succeeded | 6s | View ↗ |
nx documentation |
✅ Succeeded | 1m 25s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-09-02 11:20:44 UTC
jaysoo
approved these changes
Sep 2, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
If another plugin, or project/package.json exists in the repo that has a
serve-statictarget, runningnx add @nx/rpsackwill fail.The
@nx/rspack:initgenerator does not have any alternative names forserve-staticcausing conflicts.Expected Behavior
The
initgenerator should provide more options for theserve-statictarget such that the plugin can be added without error.