Skip to content

Commit b401e6e

Browse files
authored
feat(core): enable tui by default on windows (#33314)
## Current Behavior: Tui is working, but only able to be enabled on windows via env vars or explicit command line config ## Expected Behavior: Tui is default on
1 parent a5d34fd commit b401e6e

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

packages/nx/src/native/tui/components/help_popup.rs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,22 @@ impl HelpPopup {
186186
"https://nx.dev/terminal-ui",
187187
Style::default().fg(THEME.info),
188188
),
189+
Span::styled(
190+
"If you would prefer to not use the TUI, you can disable it by: ",
191+
Style::default().fg(THEME.info),
192+
),
193+
Span::styled(
194+
"- Adding the `--no-tui` flag to your command.",
195+
Style::default()
196+
.fg(THEME.info)
197+
.add_modifier(Modifier::ITALIC),
198+
),
199+
Span::styled(
200+
"- Setting NX_TUI=false in your environment.",
201+
Style::default()
202+
.fg(THEME.info)
203+
.add_modifier(Modifier::ITALIC),
204+
),
189205
]),
190206
Line::from(vec![
191207
Span::styled(

packages/nx/src/tasks-runner/is-tui-enabled.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ export function shouldUseTui(
2727
skipCapabilityCheck = process.env.NX_TUI_SKIP_CAPABILITY_CHECK === 'true'
2828
) {
2929
// If the current terminal/environment is not capable of displaying the TUI, we don't run it
30-
const isWindows = process.platform === 'win32';
3130
const isCapable =
3231
skipCapabilityCheck || (process.stderr.isTTY && isUnicodeSupported());
3332

@@ -74,9 +73,6 @@ export function shouldUseTui(
7473
isCI() ||
7574
// Interactive TUI doesn't make sense in an AI agent context
7675
isAiAgent() ||
77-
// TODO(@JamesHenry): Remove this check once Windows issues are fixed.
78-
// Windows is not working well right now, temporarily disable it on Windows even if it has been specified as enabled
79-
isWindows ||
8076
// WASM needs further testing
8177
IS_WASM
8278
) {

0 commit comments

Comments
 (0)